Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily register DynamicValuesPropertySource in the TestContext framework #32871

Closed
sbrannen opened this issue May 22, 2024 · 0 comments
Closed
Assignees
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone

Comments

@sbrannen
Copy link
Member

Overview

As a result of commit 6cdb344, the DynamicValuesPropertySource is now eagerly registered in the Environment even if the DynamicPropertyRegistry is never used to register dynamic properties.

Ideally, we should only register DynamicValuesPropertySource if we know that the DynamicPropertyRegistry is used -- either by a @DynamicPropertySource method in a test class or via a bean in the ApplicationContext that invokes add() on the DynamicPropertyRegistry bean.

Related Issues

@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement labels May 22, 2024
@sbrannen sbrannen added this to the 6.2.0-M3 milestone May 22, 2024
@sbrannen sbrannen self-assigned this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant