Skip to content

Trace and Span IDs are no longer propagated to Spring MVC after Async #33110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
syedyusufh opened this issue Jun 27, 2024 · 2 comments
Closed

Trace and Span IDs are no longer propagated to Spring MVC after Async #33110

syedyusufh opened this issue Jun 27, 2024 · 2 comments
Labels
status: duplicate A duplicate of another issue

Comments

@syedyusufh
Copy link

Sorry, this is to reopen #33091 and bring to your notice that

TracingContext is lost in RestControllerAdvice as well where you define ExceptionHandler for logging and throwing user defined exceptions.

Also, ResponseBodyAdvice helps customize the responseBody and definitely any info / failure there needs to be logged along with the original TraceContext

Our implementation is quite similar to what is mentioned in this official documentation page https://docs.spring.io/spring-boot/reference/web/reactive.html#web.reactive.webflux

Having this been available since atleast Spring Boot v2.5.x, kindly reconsider. Thanks
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 27, 2024
@bclozel
Copy link
Member

bclozel commented Jun 27, 2024

I'll reconsider this in the original issue. No need to create a duplicate one. Other community members are welcome to comment there as well.

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
@bclozel bclozel added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 27, 2024
@syedyusufh
Copy link
Author

Thanks @bclozel , sorry for the duplicate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bclozel @spring-projects-issues @syedyusufh