-
Notifications
You must be signed in to change notification settings - Fork 38.5k
Consider making HttpServiceProxyFactory.Builder extensible for custom configuration tracking #34144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Would this enhancement cover the use case you are trying to implement? #33992 |
Thank you for pointing me to that issue @bclozel. While the proposed registry and DSL enhancement would be valuable, I believe it addresses a different aspect of Http service proxy configuration than my use case. My use case is focused on the post-configuration phase, specifically:
While both enhancements deal with HttpServiceProxyFactory, they serve different purposes - the proposed registry helps with setting up proxies, while my request aims to enable tracking of the configured proxies during or after they're set up. Would it make sense to consider both enhancements, perhaps with the builder extensibility being a smaller, more focused change that could complement the larger registry/DSL enhancement? |
There aren't that many methods on the factory and the builder, and while it's good to know the use case, it's not very clear which methods you mean to extend or why the builder in particular. I don't think opening the factory or its builder for extension is a good direction, but would consider exposing information from it, or adding flexibility that might help your use case. For example we could keep track of the service types for which clients have been created and expose that, or provide a callback on every call to |
If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed. |
Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue. |
Hi @bclozel and @rstoyanchev, I apologize for the delayed response and I see the ticket has been closed. I just wanted to thank you both for taking the time to look into this issue. |
Hi Spring Team,
I would like to propose making
org.springframework.web.service.invoker.HttpServiceProxyFactory.Builder
non-final to allow for extension and customization of the builder process.Use Case:
In our projects, we provide the
HttpServiceProxyFactory.Builder
as a prototype-scoped bean that is used whenever@HttpExchange
is configured. We need to collect and track all endpoints that are configured for HttpExchange classes across our application for monitoring and documentation purposes. This involves:@HttpExchange
to check their base URLsLimitation:
While we can scan HttpExchange classes for base urls, we cannot capture the complete picture because the Builder class is
final
, preventing us from extending it.The text was updated successfully, but these errors were encountered: