Skip to content

Set DataLoader names when registering them #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bclozel opened this issue May 13, 2025 · 0 comments
Closed

Set DataLoader names when registering them #1211

bclozel opened this issue May 13, 2025 · 0 comments
Assignees
@bclozel
Labels
in: data Issues related to working with data type: enhancement A general enhancement
Milestone
1.4.0

Comments

@bclozel
Copy link
Member

bclozel commented May 13, 2025

As of graphql-java/java-dataloader#193, DataLoader are named.

We need to reflect this new feature in our codebase by:

  1. Fill the new name property when creating a DataLoader from a ReactorBatchLoader/ReactorMappedBatchLoader using its name
  2. Use this name property for the data loader observations, replacing the graphql.loader.type
@bclozel bclozel added this to the 1.4.0 milestone May 13, 2025
@bclozel bclozel self-assigned this May 13, 2025
@bclozel bclozel added type: enhancement A general enhancement in: data Issues related to working with data labels May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: data Issues related to working with data type: enhancement A general enhancement
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
1 participant
@bclozel