Skip to content

Commit 50cf364

Browse files
committed
Fix kafka tests according latest spring-kafka
1 parent e434a46 commit 50cf364

File tree

1 file changed

+2
-18
lines changed

1 file changed

+2
-18
lines changed

spring-integration-kafka/src/test/java/org/springframework/integration/kafka/outbound/KafkaProducerMessageHandlerTests.java

+2-18
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,9 @@
3535
import static org.springframework.kafka.test.assertj.KafkaConditions.value;
3636

3737
import java.time.Duration;
38-
import java.util.ArrayList;
3938
import java.util.Collection;
4039
import java.util.Collections;
4140
import java.util.HashMap;
42-
import java.util.List;
4341
import java.util.Map;
4442
import java.util.concurrent.CountDownLatch;
4543
import java.util.concurrent.TimeUnit;
@@ -90,7 +88,6 @@
9088
import org.springframework.kafka.support.KafkaHeaders;
9189
import org.springframework.kafka.support.KafkaNull;
9290
import org.springframework.kafka.support.SendResult;
93-
import org.springframework.kafka.support.TransactionSupport;
9491
import org.springframework.kafka.support.converter.RecordMessageConverter;
9592
import org.springframework.kafka.test.EmbeddedKafkaBroker;
9693
import org.springframework.kafka.test.utils.KafkaTestUtils;
@@ -525,13 +522,8 @@ void testConsumeAndProduceTransaction() throws Exception {
525522
return null;
526523
}).given(producer).close(any());
527524
ProducerFactory pf = mock(ProducerFactory.class);
528-
given(pf.isProducerPerConsumerPartition()).willReturn(true);
529525
given(pf.transactionCapable()).willReturn(true);
530-
final List<String> transactionalIds = new ArrayList<>();
531-
willAnswer(i -> {
532-
transactionalIds.add(TransactionSupport.getTransactionIdSuffix());
533-
return producer;
534-
}).given(pf).createProducer(isNull());
526+
willReturn(producer).given(pf).createProducer(isNull());
535527
PlatformTransactionManager ptm = new KafkaTransactionManager(pf);
536528
ContainerProperties props = new ContainerProperties("foo");
537529
props.setGroupId("group");
@@ -567,8 +559,6 @@ void testConsumeAndProduceTransaction() throws Exception {
567559
container.stop();
568560
verify(pf, times(2)).createProducer(isNull());
569561
verifyNoMoreInteractions(producer);
570-
assertThat(transactionalIds.get(0)).isEqualTo("group.foo.0");
571-
assertThat(transactionalIds.get(1)).isEqualTo("group.foo.0");
572562
}
573563

574564
@SuppressWarnings({ "rawtypes", "unchecked" })
@@ -670,17 +660,14 @@ void testConsumeAndProduceTransactionTxIdOverride() throws Exception {
670660
return null;
671661
}).given(producer).close(any());
672662
AtomicReference<String> txId = new AtomicReference<>();
673-
final List<String> transactionalIds = new ArrayList<>();
674663
DefaultKafkaProducerFactory pf = new DefaultKafkaProducerFactory(Collections.emptyMap()) {
675664

676665
@Override
677-
protected Producer createTransactionalProducerForPartition(String txIdPrefix) {
666+
protected Producer createTransactionalProducer(String txIdPrefix) {
678667
txId.set(txIdPrefix);
679-
transactionalIds.add(TransactionSupport.getTransactionIdSuffix());
680668
return producer;
681669
}
682670

683-
684671
};
685672
pf.setTransactionIdPrefix("default.tx.id.");
686673
KafkaTransactionManager tm = new KafkaTransactionManager(pf);
@@ -719,9 +706,6 @@ protected Producer createTransactionalProducerForPartition(String txIdPrefix) {
719706
inOrder.verify(producer).close(any());
720707
container.stop();
721708
verifyNoMoreInteractions(producer);
722-
assertThat(transactionalIds).hasSizeGreaterThanOrEqualTo(2);
723-
assertThat(transactionalIds.get(0)).isEqualTo("group.foo.0");
724-
assertThat(transactionalIds.get(1)).isEqualTo("group.foo.0");
725709
assertThat(txId.get()).isEqualTo("tm.tx.id.");
726710
}
727711

0 commit comments

Comments
 (0)