Skip to content

Commit 95f1eb8

Browse files
committed
GH-8616: Upgrade to Angus Mail to 2.0.2
Fixes #8616 * And Greenmail to `2.1.0`
1 parent 9752229 commit 95f1eb8

File tree

3 files changed

+9
-12
lines changed

3 files changed

+9
-12
lines changed

build.gradle

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ ext {
6565
findbugsVersion = '3.0.1'
6666
ftpServerVersion = '1.2.0'
6767
graalvmVersion = '22.3.2'
68-
greenmailVersion = '2.0.0'
68+
greenmailVersion = '2.1.0-alpha-1'
6969
groovyVersion = '4.0.12'
7070
hamcrestVersion = '2.2'
7171
hazelcastVersion = '5.2.3'
@@ -87,7 +87,7 @@ ext {
8787
kryoVersion = '5.5.0'
8888
lettuceVersion = '6.2.4.RELEASE'
8989
log4jVersion = '2.20.0'
90-
mailVersion = '1.0.0'
90+
mailVersion = '2.0.2'
9191
micrometerTracingVersion = '1.1.1'
9292
micrometerVersion = '1.11.0'
9393
mockitoVersion = '5.3.1'
@@ -809,10 +809,7 @@ project('spring-integration-mail') {
809809

810810
providedImplementation "org.eclipse.angus:jakarta.mail:$mailVersion"
811811

812-
testImplementation ("com.icegreen:greenmail:$greenmailVersion") {
813-
exclude group: 'com.sun.mail'
814-
exclude group: 'jakarta.activation'
815-
}
812+
testImplementation "com.icegreen:greenmail:$greenmailVersion"
816813

817814
testRuntimeOnly 'org.apache.logging.log4j:log4j-jul'
818815
}

spring-integration-mail/src/main/java/org/springframework/integration/mail/ImapMailReceiver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2022 the original author or authors.
2+
* Copyright 2002-2023 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -22,7 +22,6 @@
2222
import java.util.Properties;
2323
import java.util.concurrent.ScheduledFuture;
2424

25-
import com.sun.mail.imap.IMAPFolder;
2625
import jakarta.mail.Flags;
2726
import jakarta.mail.Flags.Flag;
2827
import jakarta.mail.Folder;
@@ -32,6 +31,7 @@
3231
import jakarta.mail.search.FlagTerm;
3332
import jakarta.mail.search.NotTerm;
3433
import jakarta.mail.search.SearchTerm;
34+
import org.eclipse.angus.mail.imap.IMAPFolder;
3535

3636
import org.springframework.scheduling.TaskScheduler;
3737
import org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler;

spring-integration-mail/src/test/java/org/springframework/integration/mail/ImapMailReceiverTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import java.util.Properties;
2525
import java.util.concurrent.CountDownLatch;
2626
import java.util.concurrent.ExecutionException;
27-
import java.util.concurrent.Executors;
2827
import java.util.concurrent.TimeUnit;
2928
import java.util.concurrent.atomic.AtomicInteger;
3029
import java.util.concurrent.atomic.AtomicReference;
@@ -39,7 +38,6 @@
3938
import com.icegreen.greenmail.util.GreenMailUtil;
4039
import com.icegreen.greenmail.util.ServerSetup;
4140
import com.icegreen.greenmail.util.ServerSetupTest;
42-
import com.sun.mail.imap.IMAPFolder;
4341
import jakarta.mail.Flags;
4442
import jakarta.mail.Flags.Flag;
4543
import jakarta.mail.Folder;
@@ -56,6 +54,8 @@
5654
import jakarta.mail.search.FlagTerm;
5755
import jakarta.mail.search.FromTerm;
5856
import jakarta.mail.search.SearchTerm;
57+
import org.eclipse.angus.mail.imap.IMAPFolder;
58+
import org.eclipse.angus.mail.imap.protocol.IMAPProtocol;
5959
import org.junit.jupiter.api.AfterAll;
6060
import org.junit.jupiter.api.AfterEach;
6161
import org.junit.jupiter.api.BeforeAll;
@@ -146,7 +146,7 @@ void startImapServer() throws ExecutionException, InterruptedException {
146146
imap.setServerStartupTimeout(10000);
147147
imapIdleServer = new GreenMail(imap);
148148
user = imapIdleServer.setUser("user", "pw");
149-
Executors.newSingleThreadExecutor().submit(imapIdleServer::start).get();
149+
imapIdleServer.start();
150150
}
151151

152152
@AfterEach
@@ -995,7 +995,7 @@ private static class ImapSearchLoggingHandler extends Handler {
995995

996996
@Override
997997
public void publish(LogRecord record) {
998-
if ("com.sun.mail.imap.protocol".equals(record.getLoggerName())) {
998+
if (IMAPProtocol.class.getPackageName().equals(record.getLoggerName())) {
999999
String message = record.getMessage();
10001000
if (!message.startsWith("*")) {
10011001
if (message.contains(SEARCH) && !message.contains(" OK ")) {

0 commit comments

Comments
 (0)