Skip to content

Commit 04af9f8

Browse files
author
Alexis SEGURA
committed
GH-3693: Remove outdated DLT Topic Suffix references from Javadoc, reference doc and code sample.
1 parent 64440cb commit 04af9f8

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

samples/sample-01/src/main/java/com/example/Application.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public void listen(Foo2 foo) {
7979
this.exec.execute(() -> System.out.println("Hit Enter to terminate..."));
8080
}
8181

82-
@KafkaListener(id = "dltGroup", topics = "topic1.DLT")
82+
@KafkaListener(id = "dltGroup", topics = "topic1-dlt")
8383
public void dltListen(byte[] in) {
8484
logger.info("Received from DLT: " + new String(in));
8585
this.exec.execute(() -> System.out.println("Hit Enter to terminate..."));
@@ -92,7 +92,7 @@ public NewTopic topic() {
9292

9393
@Bean
9494
public NewTopic dlt() {
95-
return new NewTopic("topic1.DLT", 1, (short) 1);
95+
return new NewTopic("topic1-dlt", 1, (short) 1);
9696
}
9797

9898
@Bean

spring-kafka-docs/src/main/antora/modules/ROOT/pages/kafka/annotation-error-handling.adoc

+1-1
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,7 @@ public ErrorHandler eh(KafkaOperations<String, String> template) {
743743
retries.value()[0]++;
744744
}
745745
return retries.value()[0] > 5
746-
? new TopicPartition("topic.DLT", rec.partition())
746+
? new TopicPartition("topic-dlt", rec.partition())
747747
: new TopicPartition("topic", rec.partition());
748748
}), new FixedBackOff(0L, 0L));
749749
}

spring-kafka/src/main/java/org/springframework/kafka/listener/DeadLetterPublishingRecoverer.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ public class DeadLetterPublishingRecoverer extends ExceptionClassifier implement
140140

141141
/**
142142
* Create an instance with the provided template and a default destination resolving
143-
* function that returns a TopicPartition based on the original topic (appended with ".DLT")
143+
* function that returns a TopicPartition based on the original topic (appended with "-dlt")
144144
* from the failed record, and the same partition as the failed record. Therefore the
145145
* dead-letter topic must have at least as many partitions as the original topic.
146146
* @param template the {@link KafkaOperations} to use for publishing.
@@ -165,7 +165,7 @@ public DeadLetterPublishingRecoverer(KafkaOperations<? extends Object, ? extends
165165
/**
166166
* Create an instance with the provided templates and a default destination resolving
167167
* function that returns a TopicPartition based on the original topic (appended with
168-
* ".DLT") from the failed record, and the same partition as the failed record.
168+
* "-dlt") from the failed record, and the same partition as the failed record.
169169
* Therefore the dead-letter topic must have at least as many partitions as the
170170
* original topic. The templates map keys are classes and the value the corresponding
171171
* template to use for objects (producer record values) of that type. A

0 commit comments

Comments
 (0)