GH-777: Reset running on stop()

garyrussell · garyrussell · commit 79c46c3fca8b · 2018-08-20T11:13:42.000-04:00
Fixes #777 So that `isRunning()` properly reflects the state. In future, consider removing `Lifecycle` and close the producer(s) with a `ContextStoppedEvent`.
diff --git a/spring-kafka/src/main/java/org/springframework/kafka/core/DefaultKafkaProducerFactory.java b/spring-kafka/src/main/java/org/springframework/kafka/core/DefaultKafkaProducerFactory.java
@@ -201,6 +201,7 @@ public void start() {
 	public void stop() {
 		try {
 			destroy();
+			this.running = false;
 		}
 		catch (Exception e) {
 			logger.error("Exception while closing producer", e);

Original file line number	Diff line number	Diff line change
`@@ -201,6 +201,7 @@ public void start() {`
`201`	`201`	`public void stop() {`
`202`	`202`	`try {`
`203`	`203`	`destroy();`
	`204`	`+ this.running = false;`
`204`	`205`	`}`
`205`	`206`	`catch (Exception e) {`
`206`	`207`	`logger.error("Exception while closing producer", e);`