Skip to content

Commit 7d19d0d

Browse files
prasanth08artembilan
authored andcommitted
Refactor - use method referencing in lambdas where possible
1 parent e5d2334 commit 7d19d0d

7 files changed

+8
-12
lines changed

Diff for: spring-kafka/src/main/java/org/springframework/kafka/listener/AbstractMessageListenerContainer.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -551,9 +551,7 @@ public final void stop(boolean wait) {
551551
}
552552
}
553553
else {
554-
doStop(() -> {
555-
publishContainerStoppedEvent();
556-
});
554+
doStop(this::publishContainerStoppedEvent);
557555
}
558556
}
559557
}

Diff for: spring-kafka/src/main/java/org/springframework/kafka/listener/ConcurrentMessageListenerContainer.java

+2-4
Original file line numberDiff line numberDiff line change
@@ -233,10 +233,8 @@ private void configureChildContainer(int index, KafkaMessageListenerContainer<K,
233233
container.setBatchInterceptor(getBatchInterceptor());
234234
container.setInterceptBeforeTx(isInterceptBeforeTx());
235235
container.setListenerInfo(getListenerInfo());
236-
container.setEmergencyStop(() -> {
237-
stopAbnormally(() -> {
238-
});
239-
});
236+
container.setEmergencyStop(() -> stopAbnormally(() -> {
237+
}));
240238
AsyncTaskExecutor exec = container.getContainerProperties().getListenerTaskExecutor();
241239
if (exec == null) {
242240
if ((this.executors.size() > index)) {

Diff for: spring-kafka/src/main/java/org/springframework/kafka/listener/ErrorHandlerAdapter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ public void handleOtherException(Exception thrownException, Consumer<?, ?> consu
118118
MessageListenerContainer container, boolean batchListener) {
119119

120120
if (this.errorHandler != null) {
121-
this.errorHandler.handle(thrownException, Collections.EMPTY_LIST, consumer, container);
121+
this.errorHandler.handle(thrownException, Collections.emptyList(), consumer, container);
122122
}
123123
else {
124124
this.batchErrorHandler.handle(thrownException, EMPTY_BATCH, consumer, container, () -> { });

Diff for: spring-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -3447,7 +3447,7 @@ public void onPartitionsRevoked(Collection<TopicPartition> partitions) {
34473447
ListenerConsumer.this.assignedPartitions.removeAll(partitions);
34483448
}
34493449
ListenerConsumer.this.pausedForNack.removeAll(partitions);
3450-
partitions.forEach(tp -> ListenerConsumer.this.lastCommits.remove(tp));
3450+
partitions.forEach(ListenerConsumer.this.lastCommits::remove);
34513451
synchronized (ListenerConsumer.this) {
34523452
if (ListenerConsumer.this.offsetsInThisBatch != null) {
34533453
partitions.forEach(tp -> {

Diff for: spring-kafka/src/main/java/org/springframework/kafka/support/KafkaUtils.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public final class KafkaUtils {
4444

4545
private static final ThreadLocal<Boolean> LOG_METADATA_ONLY = new ThreadLocal<>();
4646

47-
private static Function<ProducerRecord<?, ?>, String> prFormatter = rec -> rec.toString();
47+
private static Function<ProducerRecord<?, ?>, String> prFormatter = ProducerRecord::toString;
4848

4949
private static Function<ConsumerRecord<?, ?>, String> crFormatter =
5050
rec -> rec.topic() + "-" + rec.partition() + "@" + rec.offset();

Diff for: spring-kafka/src/main/java/org/springframework/kafka/support/serializer/DelegatingDeserializer.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ Deserializer<? extends Object> trySerdes(String key) {
214214

215215
@Override
216216
public void close() {
217-
this.delegates.values().forEach(deser -> deser.close());
217+
this.delegates.values().forEach(Deserializer::close);
218218
}
219219

220220
}

Diff for: spring-kafka/src/main/java/org/springframework/kafka/support/serializer/DelegatingSerializer.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ byte[] trySerdes(Object data) {
247247

248248
@Override
249249
public void close() {
250-
this.delegates.values().forEach(ser -> ser.close());
250+
this.delegates.values().forEach(Serializer::close);
251251
}
252252

253253
}

0 commit comments

Comments
 (0)