Skip to content

Commit ab9d645

Browse files
garyrussellartembilan
authored andcommitted
GH-2225: Fix New Package Tangle
Resolves #2255 * Also move test; fix deprecation warnings. **Cherry-pick to 2.9.x**
1 parent 76de24d commit ab9d645

File tree

7 files changed

+10
-40
lines changed

7 files changed

+10
-40
lines changed

spring-kafka/src/main/java/org/springframework/kafka/annotation/EnableKafkaRetryTopic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
import org.springframework.context.annotation.Configuration;
2626
import org.springframework.context.annotation.Import;
27-
import org.springframework.kafka.config.RetryTopicConfigurationSupport;
27+
import org.springframework.kafka.retrytopic.RetryTopicConfigurationSupport;
2828

2929
/**
3030
* Enables the non-blocking topic-based delayed retries feature. To be used in

spring-kafka/src/main/java/org/springframework/kafka/retrytopic/RetryTopicBootstrapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
*
4646
* @author Tomaz Fernandes
4747
* @since 2.7
48-
* @deprecated in favor of {@link org.springframework.kafka.config.RetryTopicConfigurationSupport}
48+
* @deprecated in favor of {@link org.springframework.kafka.retrytopic.RetryTopicConfigurationSupport}
4949
*
5050
*/
5151
@Deprecated

spring-kafka/src/main/java/org/springframework/kafka/config/RetryTopicComponentFactory.java renamed to spring-kafka/src/main/java/org/springframework/kafka/retrytopic/RetryTopicComponentFactory.java

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,31 +14,20 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.kafka.config;
17+
package org.springframework.kafka.retrytopic;
1818

1919
import java.time.Clock;
2020

2121
import org.springframework.beans.factory.BeanFactory;
22+
import org.springframework.kafka.config.KafkaListenerContainerFactory;
23+
import org.springframework.kafka.config.KafkaListenerEndpoint;
2224
import org.springframework.kafka.listener.DeadLetterPublishingRecoverer;
2325
import org.springframework.kafka.listener.KafkaBackOffManagerFactory;
2426
import org.springframework.kafka.listener.KafkaConsumerBackoffManager;
2527
import org.springframework.kafka.listener.ListenerContainerRegistry;
2628
import org.springframework.kafka.listener.MessageListenerContainer;
2729
import org.springframework.kafka.listener.PartitionPausingBackOffManagerFactory;
2830
import org.springframework.kafka.listener.adapter.KafkaBackoffAwareMessageListenerAdapter;
29-
import org.springframework.kafka.retrytopic.DeadLetterPublishingRecovererFactory;
30-
import org.springframework.kafka.retrytopic.DefaultDestinationTopicProcessor;
31-
import org.springframework.kafka.retrytopic.DefaultDestinationTopicResolver;
32-
import org.springframework.kafka.retrytopic.DestinationTopic;
33-
import org.springframework.kafka.retrytopic.DestinationTopicContainer;
34-
import org.springframework.kafka.retrytopic.DestinationTopicProcessor;
35-
import org.springframework.kafka.retrytopic.DestinationTopicResolver;
36-
import org.springframework.kafka.retrytopic.ListenerContainerFactoryConfigurer;
37-
import org.springframework.kafka.retrytopic.ListenerContainerFactoryResolver;
38-
import org.springframework.kafka.retrytopic.RetryTopicConfiguration;
39-
import org.springframework.kafka.retrytopic.RetryTopicConfigurer;
40-
import org.springframework.kafka.retrytopic.RetryTopicNamesProviderFactory;
41-
import org.springframework.kafka.retrytopic.SuffixingRetryTopicNamesProviderFactory;
4231

4332
/**
4433
* Provide the component instances that will be used with

spring-kafka/src/main/java/org/springframework/kafka/config/RetryTopicConfigurationSupport.java renamed to spring-kafka/src/main/java/org/springframework/kafka/retrytopic/RetryTopicConfigurationSupport.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.kafka.config;
17+
package org.springframework.kafka.retrytopic;
1818

1919
import java.time.Clock;
2020
import java.util.ArrayList;
@@ -32,6 +32,8 @@
3232
import org.springframework.core.task.TaskExecutor;
3333
import org.springframework.kafka.annotation.EnableKafkaRetryTopic;
3434
import org.springframework.kafka.annotation.KafkaListenerAnnotationBeanPostProcessor;
35+
import org.springframework.kafka.config.KafkaListenerConfigUtils;
36+
import org.springframework.kafka.config.KafkaListenerEndpoint;
3537
import org.springframework.kafka.listener.CommonErrorHandler;
3638
import org.springframework.kafka.listener.ConcurrentMessageListenerContainer;
3739
import org.springframework.kafka.listener.DeadLetterPublishingRecoverer;
@@ -44,18 +46,6 @@
4446
import org.springframework.kafka.listener.MessageListenerContainer;
4547
import org.springframework.kafka.listener.PartitionPausingBackOffManagerFactory;
4648
import org.springframework.kafka.listener.WakingKafkaConsumerTimingAdjuster;
47-
import org.springframework.kafka.retrytopic.DeadLetterPublishingRecovererFactory;
48-
import org.springframework.kafka.retrytopic.DefaultDestinationTopicResolver;
49-
import org.springframework.kafka.retrytopic.DestinationTopic;
50-
import org.springframework.kafka.retrytopic.DestinationTopicProcessor;
51-
import org.springframework.kafka.retrytopic.DestinationTopicResolver;
52-
import org.springframework.kafka.retrytopic.ListenerContainerFactoryConfigurer;
53-
import org.springframework.kafka.retrytopic.ListenerContainerFactoryResolver;
54-
import org.springframework.kafka.retrytopic.RetryTopicBeanNames;
55-
import org.springframework.kafka.retrytopic.RetryTopicBootstrapper;
56-
import org.springframework.kafka.retrytopic.RetryTopicConfigurer;
57-
import org.springframework.kafka.retrytopic.RetryTopicInternalBeanNames;
58-
import org.springframework.kafka.retrytopic.RetryTopicNamesProviderFactory;
5949
import org.springframework.kafka.support.JavaUtils;
6050
import org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor;
6151
import org.springframework.util.Assert;

spring-kafka/src/test/java/org/springframework/kafka/config/RetryTopicConfigurationSupportTests.java renamed to spring-kafka/src/test/java/org/springframework/kafka/retrytopic/RetryTopicConfigurationSupportTests.java

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.kafka.config;
17+
package org.springframework.kafka.retrytopic;
1818

1919
import static org.assertj.core.api.Assertions.assertThat;
2020
import static org.assertj.core.api.Assertions.assertThatThrownBy;
@@ -42,14 +42,6 @@
4242
import org.springframework.kafka.listener.KafkaConsumerBackoffManager;
4343
import org.springframework.kafka.listener.ListenerContainerRegistry;
4444
import org.springframework.kafka.listener.PartitionPausingBackOffManagerFactory;
45-
import org.springframework.kafka.retrytopic.DeadLetterPublishingRecovererFactory;
46-
import org.springframework.kafka.retrytopic.DefaultDestinationTopicResolver;
47-
import org.springframework.kafka.retrytopic.DestinationTopicProcessor;
48-
import org.springframework.kafka.retrytopic.DestinationTopicResolver;
49-
import org.springframework.kafka.retrytopic.ListenerContainerFactoryConfigurer;
50-
import org.springframework.kafka.retrytopic.ListenerContainerFactoryResolver;
51-
import org.springframework.kafka.retrytopic.RetryTopicConfigurer;
52-
import org.springframework.kafka.retrytopic.RetryTopicNamesProviderFactory;
5345
import org.springframework.kafka.support.converter.ConversionException;
5446
import org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor;
5547
import org.springframework.util.backoff.BackOff;

spring-kafka/src/test/java/org/springframework/kafka/retrytopic/RetryTopicExceptionRoutingIntegrationTests.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
import org.springframework.kafka.annotation.KafkaListener;
4444
import org.springframework.kafka.annotation.RetryableTopic;
4545
import org.springframework.kafka.config.ConcurrentKafkaListenerContainerFactory;
46-
import org.springframework.kafka.config.RetryTopicConfigurationSupport;
4746
import org.springframework.kafka.core.ConsumerFactory;
4847
import org.springframework.kafka.core.DefaultKafkaConsumerFactory;
4948
import org.springframework.kafka.core.DefaultKafkaProducerFactory;

spring-kafka/src/test/java/org/springframework/kafka/retrytopic/RetryTopicInternalBeanNamesTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2018-2021 the original author or authors.
2+
* Copyright 2018-2022 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.

0 commit comments

Comments
 (0)