You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.adoc
+5-5
Original file line number
Diff line number
Diff line change
@@ -35,7 +35,7 @@ Signing the CLA does not grant anyone commit rights to the main repository, but
35
35
36
36
1. Go to https://github.com/spring-projects/spring-kafka[https://github.com/spring-projects/spring-kafka]
37
37
2. Hit the "fork" button and choose your own GitHub account as the target
38
-
3. For more detail see http://help.github.com/fork-a-repo/[Fork A Repo].
38
+
3. For more detail see https://help.github.com/fork-a-repo/[Fork A Repo].
39
39
40
40
== Setup your Local Development Environment
41
41
@@ -56,7 +56,7 @@ _you should see branches on origin as well as upstream, including 'master' and '
56
56
- For example, to create and switch to a new branch for issue GH-123: `git checkout -b GH-123`
57
57
* You might be working on several different topic branches at any given time, but when at a stopping point for one of those branches, commit (a local operation).
58
58
* Please follow the "Commit Guidelines" described in
59
-
http://git-scm.com/book/en/Distributed-Git-Contributing-to-a-Project[this chapter of Pro Git].
59
+
https://git-scm.com/book/en/Distributed-Git-Contributing-to-a-Project[this chapter of Pro Git].
60
60
* Then to begin working on another issue (say GH-101): `git checkout GH-101`. The _-b_ flag is not needed if that
61
61
branch already exists in your local repository.
62
62
* When ready to resolve an issue or to collaborate with others, you can push your branch to origin (your fork),
@@ -74,7 +74,7 @@ add a comment about something that should be modified, or he might reject the pu
74
74
**This is the responsibility of any contributor.**
75
75
If your pull request cannot be applied cleanly, the project lead will most likely add a comment requesting that you make
76
76
it merge-able.
77
-
For a full explanation, see http://git-scm.com/book/en/Git-Branching-Rebasing[the Pro Git section on rebasing].
77
+
For a full explanation, see https://git-scm.com/book/en/Git-Branching-Rebasing[the Pro Git section on rebasing].
78
78
As stated there: _"> Often, you’ll do this to make sure your commits apply cleanly on a remote branch — perhaps in a
79
79
project to which you’re trying to contribute but that you don’t maintain."_
80
80
@@ -91,11 +91,11 @@ and merging that into the branch you are in currently)
91
91
- Then: `git pull upstream master`
92
92
- Switch back to the topic branch: `git checkout GH-123` (no -b needed since the branch already exists)
93
93
- Rebase the topic branch to minimize the distance between it and your recently synched master branch: `git rebase master`
94
-
(Again, for more detail see http://git-scm.com/book/en/Git-Branching-Rebasing[the Pro Git section on rebasing]).
94
+
(Again, for more detail see https://git-scm.com/book/en/Git-Branching-Rebasing[the Pro Git section on rebasing]).
95
95
* **Note** You cannot rebase if you have already pushed your branch to your remote because you'd be rewriting history
96
96
(see **'The Perils of Rebasing'** in the article).
97
97
If you rebase by mistake, you can undo it as discussed
98
-
http://stackoverflow.com/questions/134882/undoing-a-git-rebase[in this StackOverflow discussion].
98
+
https://stackoverflow.com/questions/134882/undoing-a-git-rebase[in this StackOverflow discussion].
99
99
Once you have published your branch, you need to merge in the master rather than rebasing.
100
100
* Now, if you issue a pull request, it is much more likely to be merged without conflicts.
101
101
Most likely, any pull request that would produce conflicts will be deferred until the issuer of that pull request makes
Here are some ways for you to get involved in the community:
62
62
63
-
* Get involved with the Spring community on the Spring Community Forums. Please help out on the [StackOverflow](http://stackoverflow.com/questions/tagged/spring-kafka) by responding to questions and joining the debate.
63
+
* Get involved with the Spring community on the Spring Community Forums. Please help out on the [StackOverflow](https://stackoverflow.com/questions/tagged/spring-kafka) by responding to questions and joining the debate.
64
64
* Create [GitHub issues](https://github.com/spring-projects/spring-kafka/issues) for bugs and new features and comment and vote on the ones that you are interested in.
65
-
* Github is for social coding: if you want to write code, we encourage contributions through pull requests from [forks of this repository](http://help.github.com/forking/). If you want to contribute code this way, please reference a JIRA ticket as well covering the specific issue you are addressing.
66
-
* Watch for upcoming articles on Spring by [subscribing](http://www.springsource.org/node/feed) to springframework.org
65
+
* Github is for social coding: if you want to write code, we encourage contributions through pull requests from [forks of this repository](https://help.github.com/forking/). If you want to contribute code this way, please reference a JIRA ticket as well covering the specific issue you are addressing.
66
+
* Watch for upcoming articles on Spring by [subscribing](https://www.springsource.org/node/feed) to springframework.org
67
67
68
68
Before we accept a non-trivial patch or pull request we will need you to sign the [contributor's agreement](https://support.springsource.com/spring_committer_signup).
69
69
Signing the contributor's agreement does not grant anyone commit rights to the main repository, but it does mean that we can accept your contributions, and you will get an author credit if we do.
Copy file name to clipboardExpand all lines: src/reference/asciidoc/kafka.adoc
+1-1
Original file line number
Diff line number
Diff line change
@@ -1682,7 +1682,7 @@ See <<annotation-error-handling>> for more information.
1682
1682
In certain scenarios, such as rebalancing, a message that has already been processed may be redelivered.
1683
1683
The framework cannot know whether such a message has been processed or not.
1684
1684
That is an application-level function.
1685
-
This is known as the http://www.enterpriseintegrationpatterns.com/patterns/messaging/IdempotentReceiver.html[Idempotent Receiver] pattern and Spring Integration provides an http://docs.spring.io/spring-integration/reference/html/messaging-endpoints-chapter.html#idempotent-receiver[implementation of it].
1685
+
This is known as the https://www.enterpriseintegrationpatterns.com/patterns/messaging/IdempotentReceiver.html[Idempotent Receiver] pattern and Spring Integration provides an https://docs.spring.io/spring-integration/reference/html/messaging-endpoints-chapter.html#idempotent-receiver[implementation of it].
1686
1686
1687
1687
The Spring for Apache Kafka project also provides some assistance by means of the `FilteringMessageListenerAdapter` class, which can wrap your `MessageListener`.
1688
1688
This class takes an implementation of `RecordFilterStrategy` in which you implement the `filter` method to signal that a message is a duplicate and should be discarded.
Copy file name to clipboardExpand all lines: src/reference/asciidoc/si-kafka.adoc
+2-2
Original file line number
Diff line number
Diff line change
@@ -4,7 +4,7 @@
4
4
This documentation pertains to versions 2.0.0 and above.
5
5
For documentation for earlier releases, see the https://github.com/spring-projects/spring-integration-kafka/blob/1.3.x/README.md[1.3.x README].
6
6
7
-
Spring Integration Kafka is now based on the http://projects.spring.io/spring-kafka/[Spring for Apache Kafka project].
7
+
Spring Integration Kafka is now based on the https://projects.spring.io/spring-kafka/[Spring for Apache Kafka project].
8
8
It provides the following components:
9
9
10
10
* <<si-outbound>>
@@ -532,7 +532,7 @@ public void in(@Header(KafkaHeaders.RECEIVED_MESSAGE_KEY) String key,
532
532
533
533
==== What's New in Spring Integration for Apache Kafka
534
534
535
-
See the http://projects.spring.io/spring-kafka/[Spring for Apache Kafka Project Page] for a matrix of compatible `spring-kafka` and `kafka-clients` versions.
535
+
See the https://projects.spring.io/spring-kafka/[Spring for Apache Kafka Project Page] for a matrix of compatible `spring-kafka` and `kafka-clients` versions.
Copy file name to clipboardExpand all lines: src/reference/asciidoc/streams.adoc
+1-1
Original file line number
Diff line number
Diff line change
@@ -80,7 +80,7 @@ public KStream<?, ?> kStream(StreamsBuilder kStreamBuilder) {
80
80
----
81
81
====
82
82
83
-
If you would like to control the lifecycle manually (for example, stopping and starting by some condition), you can reference the `StreamsBuilderFactoryBean` bean directly by using the factory bean (`&`) http://docs.spring.io/spring/docs/current/spring-framework-reference/html/beans.html#beans-factory-extension-factorybean[prefix].
83
+
If you would like to control the lifecycle manually (for example, stopping and starting by some condition), you can reference the `StreamsBuilderFactoryBean` bean directly by using the factory bean (`&`) https://docs.spring.io/spring/docs/current/spring-framework-reference/html/beans.html#beans-factory-extension-factorybean[prefix].
84
84
Since `StreamsBuilderFactoryBean` use its internal `KafkaStreams` instance, it is safe to stop and restart it again.
85
85
A new `KafkaStreams` is created on each `start()`.
86
86
You might also consider using different `StreamsBuilderFactoryBean` instances, if you would like to control the lifecycles for `KStream` instances separately.
0 commit comments