Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated DLT Topic Suffix in DeadLetterPublishingRecoverer Method Documentation #3693

Open
fcappi opened this issue Dec 23, 2024 · 1 comment · May be fixed by #3831
Open

Outdated DLT Topic Suffix in DeadLetterPublishingRecoverer Method Documentation #3693

fcappi opened this issue Dec 23, 2024 · 1 comment · May be fixed by #3831
Assignees
@sobychacko
Labels
status: waiting-for-triage type: bug
Milestone
3.3.2

Comments

@fcappi
Copy link

fcappi commented Dec 23, 2024 •
edited
Loading

In what version(s) of Spring for Apache Kafka are you seeing this issue?

3.3.0

Describe the bug

The class DeadLetterPublishingRecoverer still contains references to the old DLT topic suffix (.DLT) in method documentation, which is misleading. The change from .DLT to -dlt was done here: #3291

Expected behavior

The method documentation should be updated to reflect the current DLT topic suffix.
@sobychacko sobychacko added this to the 3.3.2 milestone Dec 23, 2024
@sobychacko
Copy link
Contributor

@fcappi Looks like there are only javadocs references to .DLT in that class. Do you see it as different? In any case, feel free to submit a PR addressing this. Thanks!

alexisgra pushed a commit to alexisgra/spring-kafka that referenced this issue Apr 2, 2025
spring-projectsGH-3693: Remove outdated DLT Topic Suffix references f…
04af9f8 
…rom Javadoc, reference doc and code sample.
@alexisgra alexisgra linked a pull request Apr 2, 2025 that will close this issue
Open
alexisgra pushed a commit to alexisgra/spring-kafka that referenced this issue Apr 3, 2025
@alexisgra
spring-projectsGH-3693: Remove outdated DLT Topic Suffix references f…
01480bc 
…rom Javadoc, reference doc and code sample.

Signed-off-by: Alexis SEGURA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobychacko sobychacko

Labels
status: waiting-for-triage type: bug
Projects
None yet
Milestone
3.3.2
Development

Successfully merging a pull request may close this issue.

GH-3693: Remove outdated DLT Topic Suffix references from Javadoc, re… alexisgra/spring-kafka
2 participants
@sobychacko @fcappi