Skip to content

Commit 8933250

Browse files
authored
Update to Brave 6.0.1 (#587)
This commit updates to the latest Brave version (6.0.1). This revealed a strange classloader issue for Zipkin2.Span when running the failover sample app during the 'test' target. To get around this issue the tracing dependencies are temporarily commented out in the failover sample app.
1 parent 34f195f commit 8933250

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

gradle/libs.versions.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[versions]
22
# product
3-
brave = "5.17.1"
3+
brave = "6.0.1"
44
caffeine = "3.1.8"
55
jackson = "2.16.1"
66
jsr305 = "3.0.2"

spring-pulsar-sample-apps/sample-failover-custom-router/build.gradle

+4-3
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,10 @@ ext['pulsar.version'] = "${pulsarVersion}"
2121
dependencies {
2222
implementation 'org.springframework.boot:spring-boot-starter-pulsar'
2323
implementation 'org.springframework.boot:spring-boot-starter-actuator'
24-
implementation 'io.micrometer:micrometer-tracing-bridge-brave'
25-
implementation 'io.zipkin.reporter2:zipkin-reporter-brave'
26-
implementation 'io.zipkin.reporter2:zipkin-sender-urlconnection'
24+
// TODO add back in once samples are not run during part of the 'test' target
25+
// implementation 'io.micrometer:micrometer-tracing-bridge-brave'
26+
// implementation 'io.zipkin.reporter2:zipkin-reporter-brave'
27+
// implementation 'io.zipkin.reporter2:zipkin-sender-urlconnection'
2728
developmentOnly 'org.springframework.boot:spring-boot-docker-compose'
2829

2930
testImplementation project(':spring-pulsar-test')

0 commit comments

Comments
 (0)