Skip to content

Commit 548dc44

Browse files
deniswrwinch
authored andcommitted
Save query parameters in WebSessionServerRequestCache
Previously, URL query parameters were lost when saving a request in WebSessionServerRequestCache. Now it is properly saved and restored. Fixes: gh-6421
1 parent 7f2f12c commit 548dc44

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

web/src/main/java/org/springframework/security/web/server/savedrequest/WebSessionServerRequestCache.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,9 @@ public Mono<ServerHttpRequest> removeMatchingRequest(
9090
}
9191

9292
private static String pathInApplication(ServerHttpRequest request) {
93-
return request.getPath().pathWithinApplication().value();
93+
String path = request.getPath().pathWithinApplication().value();
94+
String query = request.getURI().getRawQuery();
95+
return path + (query != null ? "?" + query : "");
9496
}
9597

9698
private static ServerWebExchangeMatcher createDefaultRequestMacher() {

web/src/test/java/org/springframework/security/web/server/savedrequest/WebSessionServerRequestCacheTests.java

+10
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,16 @@ public void saveRequestGetRequestWhenGetThenFound() {
4444
assertThat(saved).isEqualTo(exchange.getRequest().getURI());
4545
}
4646

47+
@Test
48+
public void saveRequestGetRequestWithQueryParamsWhenGetThenFound() {
49+
MockServerWebExchange exchange = MockServerWebExchange.from(MockServerHttpRequest.get("/secured/").queryParam("key", "value").accept(MediaType.TEXT_HTML));
50+
this.cache.saveRequest(exchange).block();
51+
52+
URI saved = this.cache.getRedirectUri(exchange).block();
53+
54+
assertThat(saved).isEqualTo(exchange.getRequest().getURI());
55+
}
56+
4757
@Test
4858
public void saveRequestGetRequestWhenFaviconThenNotFound() {
4959
MockServerWebExchange exchange = MockServerWebExchange.from(MockServerHttpRequest.get("/favicon.png").accept(MediaType.TEXT_HTML));

0 commit comments

Comments
 (0)