Skip to content

Commit 6e793e8

Browse files
ngocnhan-tran1996ngocnhan-tran1996
committed
Fix passive tests
Signed-off-by: Tran Ngoc Nhan <[email protected]>
1 parent 4d7e97b commit 6e793e8

File tree

2 files changed

+25
-23
lines changed

2 files changed

+25
-23
lines changed

‎config/src/test/java/org/springframework/security/config/http/Saml2LoginBeanDefinitionParserTests.java

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2022 the original author or authors.
2+
* Copyright 2002-2025 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -47,7 +47,6 @@
4747
import org.springframework.security.saml2.core.Saml2Utils;
4848
import org.springframework.security.saml2.core.TestSaml2X509Credentials;
4949
import org.springframework.security.saml2.provider.service.authentication.AbstractSaml2AuthenticationRequest;
50-
import org.springframework.security.saml2.provider.service.authentication.Saml2AuthenticatedPrincipal;
5150
import org.springframework.security.saml2.provider.service.authentication.Saml2AuthenticationException;
5251
import org.springframework.security.saml2.provider.service.authentication.Saml2AuthenticationToken;
5352
import org.springframework.security.saml2.provider.service.authentication.Saml2RedirectAuthenticationRequest;
@@ -75,6 +74,7 @@
7574
import static org.mockito.BDDMockito.given;
7675
import static org.mockito.Mockito.atLeastOnce;
7776
import static org.mockito.Mockito.mock;
77+
import static org.mockito.Mockito.never;
7878
import static org.mockito.Mockito.verify;
7979
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
8080
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
@@ -210,12 +210,11 @@ public void authenticateWhenAuthenticationResponseValidThenAuthenticate() throws
210210
// @formatter:off
211211
this.mvc.perform(post("/login/saml2/sso/" + relyingPartyRegistration.getRegistrationId()).param(Saml2ParameterNames.SAML_RESPONSE, SIGNED_RESPONSE))
212212
.andDo(MockMvcResultHandlers.print())
213-
.andExpect(status().is2xxSuccessful());
213+
.andExpect(status().is3xxRedirection());
214214
// @formatter:on
215215
ArgumentCaptor<Authentication> authenticationCaptor = ArgumentCaptor.forClass(Authentication.class);
216-
verify(this.authenticationSuccessHandler).onAuthenticationSuccess(any(), any(), authenticationCaptor.capture());
217-
Authentication authentication = authenticationCaptor.getValue();
218-
assertThat(authentication.getPrincipal()).isInstanceOf(Saml2AuthenticatedPrincipal.class);
216+
verify(this.authenticationSuccessHandler, never()).onAuthenticationSuccess(any(), any(),
217+
authenticationCaptor.capture());
219218
}
220219

221220
@Test
@@ -225,12 +224,11 @@ public void authenticateWhenCustomSecurityContextHolderStrategyThenUses() throws
225224
// @formatter:off
226225
this.mvc.perform(post("/login/saml2/sso/" + relyingPartyRegistration.getRegistrationId()).param(Saml2ParameterNames.SAML_RESPONSE, SIGNED_RESPONSE))
227226
.andDo(MockMvcResultHandlers.print())
228-
.andExpect(status().is2xxSuccessful());
227+
.andExpect(status().is3xxRedirection());
229228
// @formatter:on
230229
ArgumentCaptor<Authentication> authenticationCaptor = ArgumentCaptor.forClass(Authentication.class);
231-
verify(this.authenticationSuccessHandler).onAuthenticationSuccess(any(), any(), authenticationCaptor.capture());
232-
Authentication authentication = authenticationCaptor.getValue();
233-
assertThat(authentication.getPrincipal()).isInstanceOf(Saml2AuthenticatedPrincipal.class);
230+
verify(this.authenticationSuccessHandler, never()).onAuthenticationSuccess(any(), any(),
231+
authenticationCaptor.capture());
234232
SecurityContextHolderStrategy strategy = this.spring.getContext().getBean(SecurityContextHolderStrategy.class);
235233
verify(strategy, atLeastOnce()).getContext();
236234
}
@@ -242,9 +240,8 @@ public void authenticateWhenAuthenticationResponseValidThenAuthenticationSuccess
242240
// @formatter:off
243241
this.mvc.perform(post("/login/saml2/sso/" + relyingPartyRegistration.getRegistrationId()).param(Saml2ParameterNames.SAML_RESPONSE, SIGNED_RESPONSE))
244242
.andDo(MockMvcResultHandlers.print())
245-
.andExpect(status().is2xxSuccessful());
243+
.andExpect(status().is3xxRedirection());
246244
// @formatter:on
247-
verify(this.authenticationSuccessListener).onApplicationEvent(any(AuthenticationSuccessEvent.class));
248245
}
249246

250247
@Test
@@ -277,8 +274,8 @@ public void authenticateWhenCustomAuthenticationManagerThenUses() throws Excepti
277274
MockHttpServletRequestBuilder request = post("/login/saml2/sso/" + relyingPartyRegistration.getRegistrationId())
278275
.param("SAMLResponse", SIGNED_RESPONSE);
279276
// @formatter:on
280-
this.mvc.perform(request).andExpect(status().is3xxRedirection()).andExpect(redirectedUrl("/"));
281-
verify(authenticationManager).authenticate(any());
277+
this.mvc.perform(request).andExpect(status().is3xxRedirection()).andExpect(redirectedUrl("/login?error"));
278+
verify(authenticationManager, never()).authenticate(any());
282279
}
283280

284281
@Test
@@ -320,8 +317,6 @@ public void authenticateWhenCustomAuthnRequestRepositoryThenUses() throws Except
320317
SIGNED_RESPONSE);
321318
this.mvc.perform(request);
322319
verify(this.authenticationRequestRepository).loadAuthenticationRequest(any(HttpServletRequest.class));
323-
verify(this.authenticationRequestRepository).removeAuthenticationRequest(any(HttpServletRequest.class),
324-
any(HttpServletResponse.class));
325320
}
326321

327322
@Test

‎saml2/saml2-service-provider/src/test/java/org/springframework/security/saml2/provider/service/web/Saml2AuthenticationTokenConverterTests.java

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@ public void convertWhenSamlResponseThenToken() {
6767
request.setParameter(Saml2ParameterNames.SAML_RESPONSE,
6868
Saml2Utils.samlEncode("response".getBytes(StandardCharsets.UTF_8)));
6969
Saml2AuthenticationToken token = converter.convert(request);
70-
assertThat(token.getSaml2Response()).isEqualTo("response");
70+
assertThat(token.getSaml2Response())
71+
.isEqualTo(Saml2Utils.samlInflate("response".getBytes(StandardCharsets.UTF_8)));
7172
assertThat(token.getRelyingPartyRegistration().getRegistrationId())
7273
.isEqualTo(this.relyingPartyRegistration.getRegistrationId());
7374
}
@@ -81,7 +82,8 @@ public void convertWhenSamlResponseWithRelyingPartyRegistrationResolver(
8182
request.setParameter(Saml2ParameterNames.SAML_RESPONSE,
8283
Saml2Utils.samlEncode("response".getBytes(StandardCharsets.UTF_8)));
8384
Saml2AuthenticationToken token = converter.convert(request);
84-
assertThat(token.getSaml2Response()).isEqualTo("response");
85+
assertThat(token.getSaml2Response())
86+
.isEqualTo(Saml2Utils.samlInflate("response".getBytes(StandardCharsets.UTF_8)));
8587
assertThat(token.getRelyingPartyRegistration().getRegistrationId())
8688
.isEqualTo(this.relyingPartyRegistration.getRegistrationId());
8789
verify(resolver).resolve(any(), isNull());
@@ -158,15 +160,18 @@ public void convertWhenGetRequestInvalidDeflatedThenSaml2AuthenticationException
158160
}
159161

160162
@Test
161-
public void convertWhenUsingSamlUtilsBase64ThenXmlIsValid() throws Exception {
163+
public void convertWhenUsingSamlUtilsBase64ThenSaml2AuthenticationException() throws Exception {
162164
Saml2AuthenticationTokenConverter converter = new Saml2AuthenticationTokenConverter(
163165
this.relyingPartyRegistrationResolver);
164166
given(this.relyingPartyRegistrationResolver.resolve(any(HttpServletRequest.class), any()))
165167
.willReturn(this.relyingPartyRegistration);
166168
MockHttpServletRequest request = new MockHttpServletRequest();
167169
request.setParameter(Saml2ParameterNames.SAML_RESPONSE, getSsoCircleEncodedXml());
168-
Saml2AuthenticationToken token = converter.convert(request);
169-
validateSsoCircleXml(token.getSaml2Response());
170+
assertThatExceptionOfType(Saml2AuthenticationException.class).isThrownBy(() -> converter.convert(request))
171+
.withRootCauseInstanceOf(IOException.class)
172+
.satisfies(
173+
(ex) -> assertThat(ex.getSaml2Error().getErrorCode()).isEqualTo(Saml2ErrorCodes.INVALID_RESPONSE))
174+
.satisfies((ex) -> assertThat(ex.getSaml2Error().getDescription()).isEqualTo("Unable to inflate string"));
170175
}
171176

172177
@Test
@@ -187,7 +192,8 @@ public void convertWhenSavedAuthenticationRequestThenToken() {
187192
request.setParameter(Saml2ParameterNames.SAML_RESPONSE,
188193
Saml2Utils.samlEncode("response".getBytes(StandardCharsets.UTF_8)));
189194
Saml2AuthenticationToken token = converter.convert(request);
190-
assertThat(token.getSaml2Response()).isEqualTo("response");
195+
assertThat(token.getSaml2Response())
196+
.isEqualTo(Saml2Utils.samlInflate("response".getBytes(StandardCharsets.UTF_8)));
191197
assertThat(token.getRelyingPartyRegistration().getRegistrationId())
192198
.isEqualTo(this.relyingPartyRegistration.getRegistrationId());
193199
assertThat(token.getAuthenticationRequest()).isEqualTo(authenticationRequest);
@@ -210,7 +216,8 @@ public void convertWhenSavedAuthenticationRequestThenTokenWithRelyingPartyRegist
210216
request.setParameter(Saml2ParameterNames.SAML_RESPONSE,
211217
Saml2Utils.samlEncode("response".getBytes(StandardCharsets.UTF_8)));
212218
Saml2AuthenticationToken token = converter.convert(request);
213-
assertThat(token.getSaml2Response()).isEqualTo("response");
219+
assertThat(token.getSaml2Response())
220+
.isEqualTo(Saml2Utils.samlInflate("response".getBytes(StandardCharsets.UTF_8)));
214221
assertThat(token.getRelyingPartyRegistration().getRegistrationId())
215222
.isEqualTo(this.relyingPartyRegistration.getRegistrationId());
216223
assertThat(token.getAuthenticationRequest()).isEqualTo(authenticationRequest);

0 commit comments

Comments
 (0)