Skip to content

Commit 8c37f0e

Browse files
Implement Serializable for PublicKeyCredentialUserEntity
1 parent a5b0304 commit 8c37f0e

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

config/src/test/java/org/springframework/security/SpringSecurityCoreVersionSerializableTests.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,8 @@
125125
import org.springframework.security.saml2.provider.service.authentication.TestSaml2RedirectAuthenticationRequests;
126126
import org.springframework.security.web.authentication.WebAuthenticationDetails;
127127
import org.springframework.security.web.authentication.preauth.PreAuthenticatedAuthenticationToken;
128+
import org.springframework.security.web.webauthn.api.PublicKeyCredentialUserEntity;
129+
import org.springframework.security.web.webauthn.api.TestPublicKeyCredentialUserEntity;
128130

129131
import static org.assertj.core.api.Assertions.assertThat;
130132
import static org.assertj.core.api.Assertions.fail;
@@ -321,6 +323,8 @@ class SpringSecurityCoreVersionSerializableTests {
321323
token.setDetails(details);
322324
return token;
323325
});
326+
generatorByClassName.put(PublicKeyCredentialUserEntity.class,
327+
(r) -> TestPublicKeyCredentialUserEntity.userEntity().build());
324328
}
325329

326330
@ParameterizedTest

web/src/main/java/org/springframework/security/web/webauthn/api/Bytes.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@
1616

1717
package org.springframework.security.web.webauthn.api;
1818

19+
import java.io.Serializable;
1920
import java.security.SecureRandom;
2021
import java.util.Arrays;
2122
import java.util.Base64;
2223

24+
import org.springframework.security.core.SpringSecurityCoreVersion;
2325
import org.springframework.util.Assert;
2426

2527
/**
@@ -28,7 +30,9 @@
2830
* @author Rob Winch
2931
* @since 6.4
3032
*/
31-
public final class Bytes {
33+
public final class Bytes implements Serializable {
34+
35+
private static final long serialVersionUID = SpringSecurityCoreVersion.SERIAL_VERSION_UID;
3236

3337
private static final SecureRandom RANDOM = new SecureRandom();
3438

web/src/main/java/org/springframework/security/web/webauthn/api/PublicKeyCredentialUserEntity.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
package org.springframework.security.web.webauthn.api;
1818

19+
import java.io.Serializable;
20+
1921
/**
2022
* <a href=
2123
* "https://www.w3.org/TR/webauthn-3/#dictdef-publickeycredentialuserentity">PublicKeyCredentialUserEntity</a>
@@ -27,7 +29,7 @@
2729
* @since 6.4
2830
* @see org.springframework.security.web.webauthn.management.WebAuthnRelyingPartyOperations#authenticate(org.springframework.security.web.webauthn.management.RelyingPartyAuthenticationRequest)
2931
*/
30-
public interface PublicKeyCredentialUserEntity {
32+
public interface PublicKeyCredentialUserEntity extends Serializable {
3133

3234
/**
3335
* The <a href=

0 commit comments

Comments
 (0)