Skip to content

Commit fa5fc6d

Browse files
committed
Fix checkstyle errors for toLower/toUpperCase usage
1 parent 709103e commit fa5fc6d

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

web/src/main/java/org/springframework/security/web/authentication/password/HaveIBeenPwnedRestApiPasswordChecker.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import java.security.NoSuchAlgorithmException;
2222
import java.util.Collections;
2323
import java.util.List;
24+
import java.util.Locale;
2425

2526
import org.apache.commons.logging.Log;
2627
import org.apache.commons.logging.LogFactory;
@@ -63,7 +64,7 @@ public HaveIBeenPwnedRestApiPasswordChecker() {
6364
@NonNull
6465
public CompromisedPasswordDecision check(String password) {
6566
byte[] hash = this.sha1Digest.digest(password.getBytes(StandardCharsets.UTF_8));
66-
String encoded = new String(Hex.encode(hash)).toUpperCase();
67+
String encoded = new String(Hex.encode(hash)).toUpperCase(Locale.ROOT);
6768
String prefix = encoded.substring(0, PREFIX_LENGTH);
6869
String suffix = encoded.substring(PREFIX_LENGTH);
6970

web/src/main/java/org/springframework/security/web/authentication/password/HaveIBeenPwnedRestApiReactivePasswordChecker.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import java.nio.charset.StandardCharsets;
2020
import java.security.MessageDigest;
2121
import java.security.NoSuchAlgorithmException;
22+
import java.util.Locale;
2223

2324
import org.apache.commons.logging.Log;
2425
import org.apache.commons.logging.LogFactory;
@@ -67,8 +68,8 @@ public Mono<CompromisedPasswordDecision> check(String password) {
6768
}
6869

6970
private Mono<Boolean> findLeakedPassword(String encodedPassword) {
70-
String prefix = encodedPassword.substring(0, PREFIX_LENGTH).toUpperCase();
71-
String suffix = encodedPassword.substring(PREFIX_LENGTH).toUpperCase();
71+
String prefix = encodedPassword.substring(0, PREFIX_LENGTH).toUpperCase(Locale.ROOT);
72+
String suffix = encodedPassword.substring(PREFIX_LENGTH).toUpperCase(Locale.ROOT);
7273
return getLeakedPasswordsForPrefix(prefix).any((leakedPw) -> leakedPw.startsWith(suffix));
7374
}
7475

0 commit comments

Comments
 (0)