Skip to content

Commit fd54732

Browse files
author
Steve Riesenberg
committedNov 19, 2022
Default to XorCsrfTokenRequestAttributeHandler
As of gh-11960, Xor CSRF tokens are the default in 6.0. This commit makes CsrfAuthenticationStrategy consistent with CsrfFilter. Issue gh-11960 Closes gh-12235
1 parent 3f5d8b3 commit fd54732

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed
 

Diff for: ‎web/src/main/java/org/springframework/security/web/csrf/CsrfAuthenticationStrategy.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public final class CsrfAuthenticationStrategy implements SessionAuthenticationSt
4141

4242
private final CsrfTokenRepository tokenRepository;
4343

44-
private CsrfTokenRequestHandler requestHandler = new CsrfTokenRequestAttributeHandler();
44+
private CsrfTokenRequestHandler requestHandler = new XorCsrfTokenRequestAttributeHandler();
4545

4646
/**
4747
* Creates a new instance

Diff for: ‎web/src/test/java/org/springframework/security/web/csrf/CsrfAuthenticationStrategyTests.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,10 @@ public void logoutRemovesCsrfTokenAndLoadsNewDeferredCsrfToken() {
108108
verify(this.csrfTokenRepository).loadDeferredToken(this.request, this.response);
109109
// SEC-2404, SEC-2832
110110
CsrfToken tokenInRequest = (CsrfToken) this.request.getAttribute(CsrfToken.class.getName());
111-
assertThat(tokenInRequest.getToken()).isSameAs(this.generatedToken.getToken());
112-
assertThat(tokenInRequest.getHeaderName()).isSameAs(this.generatedToken.getHeaderName());
113-
assertThat(tokenInRequest.getParameterName()).isSameAs(this.generatedToken.getParameterName());
111+
assertThat(tokenInRequest.getToken()).isNotEmpty();
112+
assertThat(tokenInRequest.getToken()).isNotEqualTo(this.generatedToken.getToken());
113+
assertThat(tokenInRequest.getHeaderName()).isEqualTo(this.generatedToken.getHeaderName());
114+
assertThat(tokenInRequest.getParameterName()).isEqualTo(this.generatedToken.getParameterName());
114115
assertThat(this.request.getAttribute(this.generatedToken.getParameterName())).isSameAs(tokenInRequest);
115116
}
116117

0 commit comments

Comments
 (0)