Skip to content

Commit ff1070d

Browse files
committed
remove redundant modifiers found by checkstyle
1 parent d9016e5 commit ff1070d

File tree

124 files changed

+187
-190
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

124 files changed

+187
-190
lines changed

acl/src/main/java/org/springframework/security/acls/jdbc/AclClassIdUtils.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,14 @@ class AclClassIdUtils {
4141

4242
private ConversionService conversionService;
4343

44-
public AclClassIdUtils() {
44+
AclClassIdUtils() {
4545
GenericConversionService genericConversionService = new GenericConversionService();
4646
genericConversionService.addConverter(String.class, Long.class, new StringToLongConverter());
4747
genericConversionService.addConverter(String.class, UUID.class, new StringToUUIDConverter());
4848
this.conversionService = genericConversionService;
4949
}
5050

51-
public AclClassIdUtils(ConversionService conversionService) {
51+
AclClassIdUtils(ConversionService conversionService) {
5252
Assert.notNull(conversionService, "conversionService must not be null");
5353
this.conversionService = conversionService;
5454
}

acl/src/main/java/org/springframework/security/acls/jdbc/BasicLookupStrategy.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ private class ProcessResultSet implements ResultSetExtractor<Set<Long>> {
559559
private final Map<Serializable, Acl> acls;
560560
private final List<Sid> sids;
561561

562-
public ProcessResultSet(Map<Serializable, Acl> acls, List<Sid> sids) {
562+
ProcessResultSet(Map<Serializable, Acl> acls, List<Sid> sids) {
563563
Assert.notNull(acls, "ACLs cannot be null");
564564
this.acls = acls;
565565
this.sids = sids; // can be null
@@ -683,7 +683,7 @@ private void convertCurrentResultIntoObject(Map<Serializable, Acl> acls,
683683
private static class StubAclParent implements Acl {
684684
private final Long id;
685685

686-
public StubAclParent(Long id) {
686+
StubAclParent(Long id) {
687687
this.id = id;
688688
}
689689

cas/src/main/java/org/springframework/security/cas/jackson2/AssertionImplMixin.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ class AssertionImplMixin {
5555
* @param attributes the key/value pairs for this attribute.
5656
*/
5757
@JsonCreator
58-
public AssertionImplMixin(@JsonProperty("principal") AttributePrincipal principal,
58+
AssertionImplMixin(@JsonProperty("principal") AttributePrincipal principal,
5959
@JsonProperty("validFromDate") Date validFromDate, @JsonProperty("validUntilDate") Date validUntilDate,
6060
@JsonProperty("authenticationDate") Date authenticationDate, @JsonProperty("attributes") Map<String, Object> attributes){
6161
}
62-
}
62+
}

cas/src/main/java/org/springframework/security/cas/jackson2/AttributePrincipalImplMixin.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ class AttributePrincipalImplMixin {
5151
* @param proxyRetriever the ProxyRetriever implementation to call back to the CAS server.
5252
*/
5353
@JsonCreator
54-
public AttributePrincipalImplMixin(@JsonProperty("name") String name, @JsonProperty("attributes") Map<String, Object> attributes,
54+
AttributePrincipalImplMixin(@JsonProperty("name") String name, @JsonProperty("attributes") Map<String, Object> attributes,
5555
@JsonProperty("proxyGrantingTicket") String proxyGrantingTicket,
5656
@JsonProperty("proxyRetriever") ProxyRetriever proxyRetriever) {
5757
}
58-
}
58+
}

cas/src/main/java/org/springframework/security/cas/jackson2/CasAuthenticationTokenMixin.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class CasAuthenticationTokenMixin {
6969
* principal and how to obtain a proxy ticket for the user.
7070
*/
7171
@JsonCreator
72-
public CasAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, @JsonProperty("principal") Object principal,
72+
CasAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, @JsonProperty("principal") Object principal,
7373
@JsonProperty("credentials") Object credentials,
7474
@JsonProperty("authorities") Collection<? extends GrantedAuthority> authorities,
7575
@JsonProperty("userDetails") UserDetails userDetails, @JsonProperty("assertion") Assertion assertion) {

cas/src/main/java/org/springframework/security/cas/web/CasAuthenticationFilter.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ private boolean proxyReceptorConfigured() {
415415
private class CasAuthenticationFailureHandler implements AuthenticationFailureHandler {
416416
private final AuthenticationFailureHandler serviceTicketFailureHandler;
417417

418-
public CasAuthenticationFailureHandler(AuthenticationFailureHandler failureHandler) {
418+
CasAuthenticationFailureHandler(AuthenticationFailureHandler failureHandler) {
419419
Assert.notNull(failureHandler, "failureHandler");
420420
this.serviceTicketFailureHandler = failureHandler;
421421
}
@@ -432,4 +432,4 @@ public void onAuthenticationFailure(HttpServletRequest request,
432432
}
433433
}
434434
}
435-
}
435+
}

cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationProviderTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ public void removeTicketFromCache(String serviceTicket) {
414414
private class MockTicketValidator implements TicketValidator {
415415
private boolean returnTicket;
416416

417-
public MockTicketValidator(boolean returnTicket) {
417+
MockTicketValidator(boolean returnTicket) {
418418
this.returnTicket = returnTicket;
419419
}
420420

config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/AuthenticationConfiguration.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ private static class EnableGlobalAuthenticationAutowiredConfigurer extends
193193
private static final Log logger = LogFactory
194194
.getLog(EnableGlobalAuthenticationAutowiredConfigurer.class);
195195

196-
public EnableGlobalAuthenticationAutowiredConfigurer(ApplicationContext context) {
196+
EnableGlobalAuthenticationAutowiredConfigurer(ApplicationContext context) {
197197
this.context = context;
198198
}
199199

config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeAuthenticationProviderBeanManagerConfigurer.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class InitializeAuthenticationProviderBeanManagerConfigurer
4242
/**
4343
* @param context the ApplicationContext to look up beans.
4444
*/
45-
public InitializeAuthenticationProviderBeanManagerConfigurer(
45+
InitializeAuthenticationProviderBeanManagerConfigurer(
4646
ApplicationContext context) {
4747
this.context = context;
4848
}
@@ -83,4 +83,4 @@ private <T> T getBeanOrNull(Class<T> type) {
8383
.getBean(userDetailsBeanNames[0], type);
8484
}
8585
}
86-
}
86+
}

config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeUserDetailsBeanManagerConfigurer.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class InitializeUserDetailsBeanManagerConfigurer
4343
/**
4444
* @param context
4545
*/
46-
public InitializeUserDetailsBeanManagerConfigurer(ApplicationContext context) {
46+
InitializeUserDetailsBeanManagerConfigurer(ApplicationContext context) {
4747
this.context = context;
4848
}
4949

config/src/main/java/org/springframework/security/config/annotation/configuration/AutowireBeanFactoryObjectPostProcessor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ final class AutowireBeanFactoryObjectPostProcessor
4444
private final List<DisposableBean> disposableBeans = new ArrayList<>();
4545
private final List<SmartInitializingSingleton> smartSingletons = new ArrayList<>();
4646

47-
public AutowireBeanFactoryObjectPostProcessor(
47+
AutowireBeanFactoryObjectPostProcessor(
4848
AutowireCapableBeanFactory autowireBeanFactory) {
4949
Assert.notNull(autowireBeanFactory, "autowireBeanFactory cannot be null");
5050
this.autowireBeanFactory = autowireBeanFactory;

config/src/main/java/org/springframework/security/config/annotation/method/configuration/GlobalMethodSecuritySelector.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
*/
3737
final class GlobalMethodSecuritySelector implements ImportSelector {
3838

39-
public final String[] selectImports(AnnotationMetadata importingClassMetadata) {
39+
public String[] selectImports(AnnotationMetadata importingClassMetadata) {
4040
Class<EnableGlobalMethodSecurity> annoType = EnableGlobalMethodSecurity.class;
4141
Map<String, Object> annotationAttributes = importingClassMetadata
4242
.getAnnotationAttributes(annoType.getName(), false);

config/src/main/java/org/springframework/security/config/annotation/web/configuration/AutowiredWebSecurityConfigurersIgnoreParents.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ final class AutowiredWebSecurityConfigurersIgnoreParents {
4040

4141
private final ConfigurableListableBeanFactory beanFactory;
4242

43-
public AutowiredWebSecurityConfigurersIgnoreParents(
43+
AutowiredWebSecurityConfigurersIgnoreParents(
4444
ConfigurableListableBeanFactory beanFactory) {
4545
Assert.notNull(beanFactory, "beanFactory cannot be null");
4646
this.beanFactory = beanFactory;

config/src/main/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurer.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ private void interceptUrl(Iterable<? extends RequestMatcher> requestMatchers,
183183

184184
@Override
185185
@SuppressWarnings("rawtypes")
186-
final List<AccessDecisionVoter<?>> getDecisionVoters(H http) {
186+
List<AccessDecisionVoter<?>> getDecisionVoters(H http) {
187187
List<AccessDecisionVoter<?>> decisionVoters = new ArrayList<>();
188188
WebExpressionVoter expressionVoter = new WebExpressionVoter();
189189
expressionVoter.setExpressionHandler(getExpressionHandler(http));
@@ -192,7 +192,7 @@ final List<AccessDecisionVoter<?>> getDecisionVoters(H http) {
192192
}
193193

194194
@Override
195-
final ExpressionBasedFilterInvocationSecurityMetadataSource createMetadataSource(
195+
ExpressionBasedFilterInvocationSecurityMetadataSource createMetadataSource(
196196
H http) {
197197
LinkedHashMap<RequestMatcher, Collection<ConfigAttribute>> requestMap = REGISTRY
198198
.createRequestMap();

config/src/main/java/org/springframework/security/config/annotation/web/configurers/UrlAuthorizationConfigurer.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ public H and() {
172172
*/
173173
@Override
174174
@SuppressWarnings("rawtypes")
175-
final List<AccessDecisionVoter<?>> getDecisionVoters(H http) {
175+
List<AccessDecisionVoter<?>> getDecisionVoters(H http) {
176176
List<AccessDecisionVoter<?>> decisionVoters = new ArrayList<>();
177177
decisionVoters.add(new RoleVoter());
178178
decisionVoters.add(new AuthenticatedVoter());

config/src/main/java/org/springframework/security/config/crypto/RsaKeyConversionServicePostProcessor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ private <S, T, I> Converter<S, T> pair(Converter<S, I> one, Converter<I, T> two)
133133
private static class ConverterPropertyEditorAdapter<T> extends PropertyEditorSupport {
134134
private final Converter<String, T> converter;
135135

136-
public ConverterPropertyEditorAdapter(Converter<String, T> converter) {
136+
ConverterPropertyEditorAdapter(Converter<String, T> converter) {
137137
this.converter = converter;
138138
}
139139

config/src/main/java/org/springframework/security/config/http/AuthenticationConfigBuilder.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ final class AuthenticationConfigBuilder {
138138

139139
private String openIDLoginPage;
140140

141-
public AuthenticationConfigBuilder(Element element, boolean forceAutoConfig,
141+
AuthenticationConfigBuilder(Element element, boolean forceAutoConfig,
142142
ParserContext pc, SessionCreationPolicy sessionPolicy,
143143
BeanReference requestCache, BeanReference authenticationManager,
144144
BeanReference sessionStrategy, BeanReference portMapper,

config/src/main/java/org/springframework/security/config/http/HttpConfigurationBuilder.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ class HttpConfigurationBuilder {
152152
private BeanDefinition invalidSession;
153153
private boolean addAllAuth;
154154

155-
public HttpConfigurationBuilder(Element element, boolean addAllAuth,
155+
HttpConfigurationBuilder(Element element, boolean addAllAuth,
156156
ParserContext pc, BeanReference portMapper, BeanReference portResolver,
157157
BeanReference authenticationManager) {
158158
this.httpElt = element;

config/src/main/java/org/springframework/security/config/http/HttpSecurityBeanDefinitionParser.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -415,12 +415,12 @@ class OrderDecorator implements Ordered {
415415
final BeanMetadataElement bean;
416416
final int order;
417417

418-
public OrderDecorator(BeanMetadataElement bean, SecurityFilters filterOrder) {
418+
OrderDecorator(BeanMetadataElement bean, SecurityFilters filterOrder) {
419419
this.bean = bean;
420420
this.order = filterOrder.getOrder();
421421
}
422422

423-
public OrderDecorator(BeanMetadataElement bean, int order) {
423+
OrderDecorator(BeanMetadataElement bean, int order) {
424424
this.bean = bean;
425425
this.order = order;
426426
}

config/src/main/java/org/springframework/security/config/http/LogoutBeanDefinitionParser.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class LogoutBeanDefinitionParser implements BeanDefinitionParser {
4848
private ManagedList<BeanMetadataElement> logoutHandlers = new ManagedList<>();
4949
private boolean csrfEnabled;
5050

51-
public LogoutBeanDefinitionParser(String loginPageUrl, String rememberMeServices,
51+
LogoutBeanDefinitionParser(String loginPageUrl, String rememberMeServices,
5252
BeanMetadataElement csrfLogoutHandler) {
5353
this.defaultLogoutUrl = loginPageUrl + "?logout";
5454
this.rememberMeServices = rememberMeServices;

config/src/main/java/org/springframework/security/config/method/ProtectPointcutPostProcessor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ final class ProtectPointcutPostProcessor implements BeanPostProcessor {
6868
private final PointcutParser parser;
6969
private final Set<String> processedBeans = new HashSet<>();
7070

71-
public ProtectPointcutPostProcessor(
71+
ProtectPointcutPostProcessor(
7272
MapBasedMethodSecurityMetadataSource mapBasedMethodSecurityMetadataSource) {
7373
Assert.notNull(mapBasedMethodSecurityMetadataSource,
7474
"MapBasedMethodSecurityMetadataSource to populate is required");

config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -3645,7 +3645,7 @@ private static class OrderedWebFilter implements WebFilter, Ordered {
36453645
private final WebFilter webFilter;
36463646
private final int order;
36473647

3648-
public OrderedWebFilter(WebFilter webFilter, int order) {
3648+
OrderedWebFilter(WebFilter webFilter, int order) {
36493649
this.webFilter = webFilter;
36503650
this.order = order;
36513651
}

config/src/main/java/org/springframework/security/config/websocket/WebSocketMessageBrokerSecurityBeanDefinitionParser.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,7 @@ static class MessageSecurityPostProcessor implements
243243

244244
private final boolean sameOriginDisabled;
245245

246-
public MessageSecurityPostProcessor(String inboundSecurityInterceptorId,
247-
boolean sameOriginDisabled) {
246+
MessageSecurityPostProcessor(String inboundSecurityInterceptorId, boolean sameOriginDisabled) {
248247
this.inboundSecurityInterceptorId = inboundSecurityInterceptorId;
249248
this.sameOriginDisabled = sameOriginDisabled;
250249
}

config/src/test/java/org/springframework/security/config/annotation/SecurityConfigurerAdapterTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public void postProcessObjectPostProcessorsAreSorted() {
4141
static class OrderedObjectPostProcessor implements ObjectPostProcessor<String>, Ordered {
4242
private final int order;
4343

44-
public OrderedObjectPostProcessor(int order) {
44+
OrderedObjectPostProcessor(int order) {
4545
this.order = order;
4646
}
4747

config/src/test/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurerTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -847,7 +847,7 @@ protected SecurityExpressionOperations createSecurityExpressionRoot(
847847

848848
static class CustomExpressionRoot extends WebSecurityExpressionRoot {
849849

850-
public CustomExpressionRoot(Authentication a, FilterInvocation fi) {
850+
CustomExpressionRoot(Authentication a, FilterInvocation fi) {
851851
super(a, fi);
852852
}
853853

config/src/test/java/org/springframework/security/config/annotation/web/configurers/NamespaceHttpExpressionHandlerTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public void getWhenHasCustomExpressionHandlerThenMatchesNamespace() throws Excep
7373
@EnableWebMvc
7474
@EnableWebSecurity
7575
private static class ExpressionHandlerConfig extends WebSecurityConfigurerAdapter {
76-
public ExpressionHandlerConfig() {}
76+
ExpressionHandlerConfig() {}
7777

7878
@Override
7979
protected void configure(AuthenticationManagerBuilder auth) throws Exception {

config/src/test/java/org/springframework/security/config/annotation/web/configurers/SecurityContextConfigurerTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public void securityContextWhenSecurityContextRepositoryNotConfiguredThenDoesNot
129129
@Configuration
130130
@EnableWebSecurity
131131
static class SecurityContextRepositoryDefaultsSecurityContextRepositoryConfig extends WebSecurityConfigurerAdapter {
132-
public SecurityContextRepositoryDefaultsSecurityContextRepositoryConfig() {
132+
SecurityContextRepositoryDefaultsSecurityContextRepositoryConfig() {
133133
super(true);
134134
}
135135

config/src/test/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/resource/OAuth2ResourceServerConfigurerTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -2133,7 +2133,7 @@ public MockWebServer web() {
21332133

21342134
private class MockWebServerPropertySource extends PropertySource {
21352135

2136-
public MockWebServerPropertySource() {
2136+
MockWebServerPropertySource() {
21372137
super("mockwebserver");
21382138
}
21392139

@@ -2178,7 +2178,7 @@ private static class BearerTokenRequestPostProcessor implements RequestPostProce
21782178

21792179
private String token;
21802180

2181-
public BearerTokenRequestPostProcessor(String token) {
2181+
BearerTokenRequestPostProcessor(String token) {
21822182
this.token = token;
21832183
}
21842184

config/src/test/java/org/springframework/security/config/http/CsrfConfigTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -631,7 +631,7 @@ public void match(MvcResult result) throws Exception {
631631
static class CsrfReturnedResultMatcher implements ResultMatcher {
632632
ExceptionalFunction<MvcResult, String> token;
633633

634-
public CsrfReturnedResultMatcher(ExceptionalFunction<MvcResult, String> token) {
634+
CsrfReturnedResultMatcher(ExceptionalFunction<MvcResult, String> token) {
635635
this.token = token;
636636
}
637637

config/src/test/java/org/springframework/security/config/http/HttpConfigTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public void getWhenUsingMinimalConfigurationThenPreventsSessionAsUrlParameter()
8383
private static class EncodeUrlDenyingHttpServletResponseWrapper
8484
extends HttpServletResponseWrapper {
8585

86-
public EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
86+
EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
8787
super(response);
8888
}
8989

config/src/test/java/org/springframework/security/config/http/MiscHttpConfigTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -907,7 +907,7 @@ public Authentication authenticate(Authentication authentication) {
907907
static class EncodeUrlDenyingHttpServletResponseWrapper
908908
extends HttpServletResponseWrapper {
909909

910-
public EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
910+
EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
911911
super(response);
912912
}
913913

config/src/test/java/org/springframework/security/config/http/SessionManagementConfigTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@ private static MockHttpServletResponse request(
610610
private static class EncodeUrlDenyingHttpServletResponseWrapper
611611
extends HttpServletResponseWrapper {
612612

613-
public EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
613+
EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
614614
super(response);
615615
}
616616

config/src/test/java/org/springframework/security/htmlunit/server/HtmlUnitWebTestClient.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ final class HtmlUnitWebTestClient {
5151

5252
private final WebTestClient webTestClient;
5353

54-
public HtmlUnitWebTestClient(WebClient webClient, WebTestClient webTestClient) {
54+
HtmlUnitWebTestClient(WebClient webClient, WebTestClient webTestClient) {
5555
Assert.notNull(webClient, "WebClient must not be null");
5656
Assert.notNull(webTestClient, "WebTestClient must not be null");
5757
this.webClient = webClient;

config/src/test/java/org/springframework/security/htmlunit/server/MockWebResponseBuilder.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ final class MockWebResponseBuilder {
4242
private final FluxExchangeResult<String> exchangeResult;
4343

4444

45-
public MockWebResponseBuilder(long startTime, WebRequest webRequest, FluxExchangeResult<String> exchangeResult) {
45+
MockWebResponseBuilder(long startTime, WebRequest webRequest, FluxExchangeResult<String> exchangeResult) {
4646
Assert.notNull(webRequest, "WebRequest must not be null");
4747
Assert.notNull(exchangeResult, "FluxExchangeResult must not be null");
4848
this.startTime = startTime;

core/src/main/java/org/springframework/security/access/expression/method/MethodSecurityEvaluationContext.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,11 @@ class MethodSecurityEvaluationContext extends StandardEvaluationContext {
4848
* for each instance. Use the constructor which takes the resolver, as an argument
4949
* thus allowing for caching.
5050
*/
51-
public MethodSecurityEvaluationContext(Authentication user, MethodInvocation mi) {
51+
MethodSecurityEvaluationContext(Authentication user, MethodInvocation mi) {
5252
this(user, mi, new DefaultSecurityParameterNameDiscoverer());
5353
}
5454

55-
public MethodSecurityEvaluationContext(Authentication user, MethodInvocation mi,
55+
MethodSecurityEvaluationContext(Authentication user, MethodInvocation mi,
5656
ParameterNameDiscoverer parameterNameDiscoverer) {
5757
this.mi = mi;
5858
this.parameterNameDiscoverer = parameterNameDiscoverer;

core/src/main/java/org/springframework/security/access/method/DelegatingMethodSecurityMetadataSource.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ private static class DefaultCacheKey {
116116
private final Method method;
117117
private final Class<?> targetClass;
118118

119-
public DefaultCacheKey(Method method, Class<?> targetClass) {
119+
DefaultCacheKey(Method method, Class<?> targetClass) {
120120
this.method = method;
121121
this.targetClass = targetClass;
122122
}

core/src/main/java/org/springframework/security/access/method/MapBasedMethodSecurityMetadataSource.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ private static class RegisteredMethod {
287287
private final Method method;
288288
private final Class<?> registeredJavaType;
289289

290-
public RegisteredMethod(Method method, Class<?> registeredJavaType) {
290+
RegisteredMethod(Method method, Class<?> registeredJavaType) {
291291
Assert.notNull(method, "Method required");
292292
Assert.notNull(registeredJavaType, "Registered Java Type required");
293293
this.method = method;

0 commit comments

Comments
 (0)