Skip to content

Fix broken link about Squashing Commits #6181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzheaux opened this issue Nov 28, 2018 · 2 comments
Closed

Fix broken link about Squashing Commits #6181

jzheaux opened this issue Nov 28, 2018 · 2 comments
Labels
in: docs An issue in Documentation or samples status: first-timers-only An issue that can only be worked on by brand new contributors type: bug A general bug

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Nov 28, 2018

The contribution guidelines link to a guide about squashing commits, but that link is broken.

Let's change it to https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

@jzheaux jzheaux added in: docs An issue in Documentation or samples type: bug A general bug labels Nov 28, 2018
@rwinch rwinch added status: ideal-for-contribution An issue that we actively are looking for someone to help us with status: first-timers-only An issue that can only be worked on by brand new contributors labels Nov 30, 2018
@mibo
Copy link
Contributor

mibo commented Nov 30, 2018

Fixing documentation is not so popular.
At least this is my explanation why this 'first-timer' is open longer then a day ;o)
However I want to contribute and I additionally know that documentation is important.

Here is the PR: #6203

For the case is missed something please let me know.

@rwinch
Copy link
Member

rwinch commented Nov 30, 2018

Thanks for the PR @mibo! This is now merged into master

We hope to see you contribute again soon! If you are looking for issues we have been adding help wanted label to issues that are a bit less challenging. Of course if you find any issue you want to work on, just mention it in the comments and we can go from there. Thanks again for taking the time to help make the Spring community better!

@rwinch rwinch closed this as completed Nov 30, 2018
@rwinch rwinch removed status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples status: first-timers-only An issue that can only be worked on by brand new contributors type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants