Skip to content

Rename SessionIdGenerationStrategy to SessionIdGenerator #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marcusdacoregio opened this issue Aug 2, 2023 · 1 comment
Closed

Rename SessionIdGenerationStrategy to SessionIdGenerator #2391

marcusdacoregio opened this issue Aug 2, 2023 · 1 comment
Assignees
@marcusdacoregio
Labels
in: core type: enhancement A general enhancement
Milestone
3.2.0-RC1

Comments

@marcusdacoregio
Copy link
Contributor

We should change the name of the interface SessionIdGenerationStrategy to SessionIdGenerator for a couple of reasons:

  • There is no need for the Strategy suffix
  • The name is not too clear, SessionIdGenerator gives a better idea of what it is for
  • Tomcat has a SessionIdGenerator and WebFlux uses IdGenerator, so we would not deviate too much
@marcusdacoregio marcusdacoregio added this to the 3.2.0-RC1 milestone Aug 2, 2023
@marcusdacoregio marcusdacoregio self-assigned this Aug 2, 2023
@rishiraj88
Copy link

Nice points by @marcusdacoregio .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: core type: enhancement A general enhancement
Projects
Spring Security Team
Archived in project
Milestone
3.2.0-RC1
Development

No branches or pull requests
2 participants
@marcusdacoregio @rishiraj88