Skip to content

spring-ws-support should not have split packages with spring-ws-core #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fhaubold opened this issue May 21, 2021 · 2 comments
Closed

spring-ws-support should not have split packages with spring-ws-core #1202

fhaubold opened this issue May 21, 2021 · 2 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@fhaubold
Copy link

Dear Spring WS team,

I want my application to use the Java Module System which does not allow shared packages between modules. My project imports two dependencies, spring-ws-core and spring-ws-support and does not compile with the following split package error:

module x reads package org.springframework.ws.transport.support from both spring.ws.support and spring.ws.core

Are there any plans to solve this issue by either rename one of the packages or move the classes into one dependency?
Is there a workaround until then? I already tried to use --patch-module without success.

Thank you!

Version: 3.1.1
JDK: corretto-11.0.11

@snicoll snicoll added the status: waiting-for-triage An issue we've not yet triaged label Feb 19, 2025
@snicoll
Copy link
Member

snicoll commented Mar 7, 2025

Thanks for the report, and sorry it took so long to triage it.

I've noticed the split package recently and I think it's a bit late to deprecate/move those classes in 4.0.x but I want to deprecate them in 4.1.x so that I can remove them in 5.0.0.

@snicoll snicoll changed the title Split package between spring-ws-core and spring-ws-support Deprecate and move classes in spring-ws-support that are located in a package of spring-ws-core Mar 7, 2025
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 7, 2025
@snicoll snicoll added this to the 4.1.0-M1 milestone Mar 7, 2025
@snicoll
Copy link
Member

snicoll commented Mar 8, 2025

Once we manage to remove them, we should remove the related Checkstyle exclusions as well.

@snicoll snicoll changed the title Deprecate and move classes in spring-ws-support that are located in a package of spring-ws-core spring-ws-support should not have split packages with spring-ws-core Mar 11, 2025
@snicoll snicoll self-assigned this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants