code review

Author: bnasslahsen

Diff for: springdoc-openapi-common/src/main/java/org/springdoc/core/AbstractRequestBuilder.java

@@ -49,7 +49,6 @@
 import io.swagger.v3.oas.models.media.Schema;
 import io.swagger.v3.oas.models.parameters.Parameter;
 import org.apache.commons.lang3.StringUtils;
-import org.springdoc.core.RequestInfo.ParameterType;
 import org.springdoc.core.customizers.OperationCustomizer;
 import org.springdoc.core.customizers.ParameterCustomizer;
 
@@ -266,14 +265,14 @@ private Parameter buildParams(ParameterInfo parameterInfo, Components components
 		RequestInfo requestInfo;
 
 		if (requestHeader != null) {
-			requestInfo = new RequestInfo(ParameterType.HEADER_PARAM, requestHeader.value(), requestHeader.required(),
+			requestInfo = new RequestInfo(ParameterIn.HEADER.toString(), requestHeader.value(), requestHeader.required(),
 					requestHeader.defaultValue());
 			parameter = buildParam(parameterInfo, components, requestInfo, jsonView);
 
 		}
 		else if (requestParam != null && !parameterBuilder.isFile(parameterInfo.getParameter())) {
 			boolean isOptional = Optional.class.equals(parameters.getType());
-			requestInfo = new RequestInfo(ParameterType.QUERY_PARAM, requestParam.value(), requestParam.required() && !isOptional,
+			requestInfo = new RequestInfo(ParameterIn.QUERY.toString(), requestParam.value(), requestParam.required() && !isOptional,
 					requestParam.defaultValue());
 			parameter = buildParam(parameterInfo, components, requestInfo, jsonView);
 		}
@@ -282,10 +281,10 @@ else if (pathVar != null) {
 			String name = StringUtils.isBlank(pathVar.value()) ? pName : pathVar.value();
 			parameterInfo.setpName(name);
 			// check if PATH PARAM
-			requestInfo = new RequestInfo(ParameterType.PATH_PARAM, pathVar.value(), Boolean.TRUE, null);
+			requestInfo = new RequestInfo(ParameterIn.PATH.toString(), pathVar.value(), Boolean.TRUE, null);
 			parameter = buildParam(parameterInfo, components, requestInfo, jsonView);
 		} else if (cookieValue != null) {
-			requestInfo = new RequestInfo(ParameterType.COOKIE, cookieValue.value(), cookieValue.required(),
+			requestInfo = new RequestInfo(ParameterIn.COOKIE.toString(), cookieValue.value(), cookieValue.required(),
 					cookieValue.defaultValue());
 			parameter = buildParam(parameterInfo, components, requestInfo, jsonView);
 		}

Diff for: springdoc-openapi-common/src/main/java/org/springdoc/core/RequestInfo.java

@@ -26,9 +26,9 @@ public class RequestInfo {
 
 	private final String defaultValue;
 
-	private final ParameterType paramType;
+	private final String paramType;
 
-	public RequestInfo(ParameterType paramType, String value, boolean required, String defaultValue) {
+	public RequestInfo(String paramType, String value, boolean required, String defaultValue) {
 		this.value = value;
 		this.required = required;
 		this.defaultValue = defaultValue;
@@ -51,19 +51,4 @@ public String type() {
 		return paramType.toString();
 	}
 
-	public enum ParameterType {
-		QUERY_PARAM("query"), HEADER_PARAM("header"), PATH_PARAM("path"), COOKIE("cookie");
-
-		private final String value;
-
-		ParameterType(String s) {
-			value = s;
-		}
-
-		@Override
-		public String toString() {
-			return value;
-		}
-	}
-
 }

Diff for: springdoc-openapi-data-rest/src/main/java/org/springdoc/core/SpringDocDataRestConfiguration.java

@@ -30,6 +30,7 @@
 import io.swagger.v3.oas.models.media.StringSchema;
 import org.springdoc.core.converters.PageableSupportConverter;
 import org.springdoc.core.customizers.OpenApiCustomiser;
+
 import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
@@ -76,7 +77,7 @@ public OpenApiCustomiser linksSchemaCustomiser(RepositoryRestConfiguration repos
 						.additionalProperties(new ObjectSchema().$ref("#/components/schemas/Link")));
     }
 
-    static abstract class RepresentationModelLinksOASMixin extends RepresentationModelMixin {
+	abstract static class RepresentationModelLinksOASMixin extends RepresentationModelMixin {
         @Override
         @Schema(ref = "#/components/schemas/Links")
         public abstract Links getLinks();