We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The method signature of PropertyCustomizer.customize declares that it returns Schema but the return value is ignored. If you look at https://github.com/springdoc/springdoc-openapi/blob/master/springdoc-openapi-common/src/main/java/org/springdoc/core/converters/PropertyCustomizingConverter.java#L44 you can see that PropertyCustomizer instances are invoked in a forEach so while they can mutate their property parameter, their return value is never used. That means PropertyCustomizer instances cannot (easily) replace the default schema. Also since the property parameter can sometimes be null there are situations in which they cannot be effective at all.
PropertyCustomizer.customize
Schema
PropertyCustomizer
forEach
property
null
The text was updated successfully, but these errors were encountered:
cdc3f1e
Hi @robfletcher,
Thank you for your feedback. A fix for this issue will be available on the next release v1.2.32.
Sorry, something went wrong.
No branches or pull requests
The method signature of
PropertyCustomizer.customize
declares that it returnsSchema
but the return value is ignored. If you look at https://github.com/springdoc/springdoc-openapi/blob/master/springdoc-openapi-common/src/main/java/org/springdoc/core/converters/PropertyCustomizingConverter.java#L44 you can see thatPropertyCustomizer
instances are invoked in aforEach
so while they can mutate theirproperty
parameter, their return value is never used. That meansPropertyCustomizer
instances cannot (easily) replace the default schema. Also since theproperty
parameter can sometimes benull
there are situations in which they cannot be effective at all.The text was updated successfully, but these errors were encountered: