Skip to content

No trailing comma in single line #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dereuromark opened this issue Jan 13, 2022 · 0 comments · Fixed by #313
Closed

No trailing comma in single line #312

dereuromark opened this issue Jan 13, 2022 · 0 comments · Fixed by #313
Labels
bug

Comments

@dereuromark
Copy link
Contributor

dereuromark commented Jan 13, 2022 •
edited
Loading 

fn($a, $b,)

=>

fn($a, $b)

As per slevomat/coding-standard#1326

Also refs squizlabs/PHP_CodeSniffer#3477 (side effect of not having this sniff!)
We should be able to revert
0edfae1

We can start easy by checking if any closing token comes afterwards, ), ], or alike.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add DisallowTrailingCommaInSingleLine to avoid side effects. spryker/code-sniffer
1 participant
@dereuromark