Skip to content

Commit b4fce40

Browse files
hungry1526wangkuiyi
authored andcommitted
Reduce unnecessary readme.md (#385)
* Reduce unnecessary readme.md * Revert "Reduce unnecessary readme.md" This reverts commit 7b4835b. * Address comments for issue 385
1 parent 016e0d0 commit b4fce40

File tree

7 files changed

+30
-134
lines changed

7 files changed

+30
-134
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

+12-14
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,26 @@
11
---
2-
name: Bug report
2+
name: Bug Report
33
about: Create a report to help us improve
44
title: ''
55
labels: ''
66
assignees: ''
77

88
---
99

10-
**Describe the bug**
11-
A clear and concise description of what the bug is.
10+
**Description**
11+
A clear description of the bug
1212

13-
**To Reproduce**
14-
Steps to reproduce the behavior.
13+
**Reproduction Steps**
14+
Detailed steps to reproduce
1515

16-
**Expected behavior**
17-
A clear and concise description of what you expected to happen.
16+
**Expected Behavior**
17+
What you expected to happen.
1818

1919
**Screenshots**
20-
If applicable, add screenshots to help explain your problem.
2120

22-
**Environment (please complete the following information):**
23-
- OS: [e.g. iOS]
24-
- Browser [e.g. chrome, safari]
25-
- Version [e.g. 22]
21+
**Environment (Please complete the following information):**
22+
- OS:
23+
- Browser:
24+
- Version:
2625

27-
**Additional context**
28-
Add any other context about the problem here.
26+
**Additional Notes**
+6-7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
name: Feature request
2+
name: Feature Request
33
about: Suggest an idea for this project
44
title: ''
55
labels: ''
@@ -8,13 +8,12 @@ assignees: ''
88
---
99

1010
**Is your feature request related to a problem? Please describe.**
11-
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
11+
A clear description of the problem
1212

1313
**Describe the solution you'd like**
14-
A clear and concise description of what you want to happen.
14+
A clear description of what you want to happen
1515

16-
**Describe alternatives you've considered (This is optional)**
17-
A clear and concise description of any alternative solutions or features you've considered.
16+
**Describe alternatives (optional)**
17+
A clear description of any alternative solutions or features
1818

19-
**Additional context**
20-
Add any other context or screenshots about the feature request here.
19+
**Additional Notes**

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ Done predicting. Predict table : iris.predict
5656

5757
## Contributions
5858

59-
- [Build from source code](doc/build.md).
59+
- [Build from source](doc/build.md)
6060
- [The walkthrough of the source code](doc/walkthrough.md)
6161
- [The choice of parser generator](doc/sql_parser.md)
6262

cmd/demo/README.md

-82
This file was deleted.

doc/installation.md

+5-12
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
# Installation
22

33
SQLFlow is currently under active development. For those who are interested in trying
4-
it out, we have provided the instructions and demo. Play around with it. Any bug report and
5-
issue is welcome. :)
4+
it out, we have provided the instructions and demo. Play around with it. Any bug report and issue is welcome. :)
65

76

87
## Preparation
@@ -37,22 +36,16 @@ issue is welcome. :)
3736
If you have your own database setup, below steps enables running a seperated container
3837
that runs SQLFlow server and Jupyter Notebook, which connects to your own database.
3938

40-
1. Follow steps in
41-
[example/datasets](https://github.com/sql-machine-learning/sqlflow/blob/develop/example/datasets)
42-
to import sample data.
39+
1. Follow steps in [example/datasets](https://github.com/sql-machine-learning/sqlflow/blob/develop/example/datasets) to import sample data.
4340

44-
1. After data is popularized in MySQL, let's test the installation from running a query in Jupyter
45-
Notebook. If you are using Docker for Linux, please change `host.docker.internal:3306` to
46-
`localhost:3306`. If you are connecting to a remote database, please make sure to change
47-
`host.docker.internal:3306` to the remote address.
41+
1. After data is popularized in MySQL, let's test the installation by running a query in Jupyter Notebook. If you are using Docker for Linux, please change `host.docker.internal:3306` to `localhost:3306`. If you are connecting to a remote database, please make sure to change `host.docker.internal:3306` to the remote address.
4842

4943
```
5044
docker run -it -p 8888:8888 sqlflow/sqlflow:latest \
5145
bash -c "sqlflowserver --datasource='mysql://root:root@tcp(host.docker.internal:3306)/?maxAllowedPacket=0' &
5246
SQLFLOW_SERVER=localhost:50051 jupyter notebook --ip=0.0.0.0 --port=8888 --allow-root"
5347
```
5448

55-
If you are using Docker for Mac, please be aware the option `--database` where `host.docker.internal` translates to the host IP address as recommended [here](https://docs.docker.com/docker-for-mac/networking/).
49+
If you are using Docker for Mac, please be aware the option `--database` where `host.docker.internal` translates to the host IP address as recommended [here](https://docs.docker.com/docker-for-mac/networking/).
5650

57-
If you are running MySQL on remote, please be aware that MySQL only allows connections from localhost
58-
by default. Fix can be found [here](https://stackoverflow.com/questions/14779104/how-to-allow-remote-connection-to-mysql).
51+
If you are running MySQL on remote, please be aware that MySQL only allows connections from localhost by default. Fix can be found [here](https://stackoverflow.com/questions/14779104/how-to-allow-remote-connection-to-mysql).

index.html

+6-4
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
need it because github.com/sql-machine-larning/sqlflow is too long a
55
Go import name. We want it to be sqlflow.org/sqlflow.
66
7-
Our solution is to build a Web site https://sqlflow.org, whose page
7+
Our solution is to build a Website https://sqlflow.org, whose page
88
http://sqlflow.org/sqlflow/index.html contains some meta information
99
readable by the Go toolchain, so that the `go get` command knows that
1010
`import sqlflow.org/sqlflow` actually redirects to `import
1111
github.com/sql-machine-larning/sqlflow `.
1212
13-
We build the Web site by the following steps.
13+
We build the Website by the following steps.
1414
1515
1. We configure https://sqlflow.org pointing to
1616
http://sql-machine-learning.github.io, which is a Github Page Web site
@@ -25,7 +25,9 @@
2525
3. We put the meta information in this file as follows.
2626
2727
Similarly, please don't remove any index.html in this repo that were
28-
marked generated by https://github.com/bramp/goredirects. -->
28+
marked generated by https://github.com/bramp/goredirects.
29+
-->
30+
2931
<html>
3032
<head>
3133
<meta name="go-import" content="sqlflow.org/sqlflow git https://github.com/sql-machine-learning/sqlflow">
@@ -38,4 +40,4 @@
3840
<body>
3941
<h1>Redirecting to <a href="https://github.com/sql-machine-learning/sqlflow">https://github.com/sql-machine-learning/sqlflow</a></h1>
4042
</body>
41-
</html>
43+
</html>

server/README.md

-14
This file was deleted.

0 commit comments

Comments
 (0)