Skip to content

Commit 8b7e97b

Browse files
authored
[release]: bump version to 2.2.0 & remove separate concurrency version (#191)
(major) version bump and minor cleanup - remove WORKFLOW_CONCURRENCY_VERSION & related code/docs - bump WORKFLOW_VERSION to 2.2.0 (to align with what the concurrency version would have been)
1 parent 9fbed9a commit 8b7e97b

File tree

4 files changed

+9
-21
lines changed

4 files changed

+9
-21
lines changed

RELEASING.md

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,7 @@ For Squares, membership is managed through the `Workflow Swift Owners` registry
1717

1818
> ⚠️ [Optional] To avoid possible headaches when publishing podspecs, validation can be performed before updating the Workflow version number(s). To do this, run the following in the root directory of this repo:
1919
> ```bash
20-
> bundle exec pod lib lint Workflow.podspec WorkflowTesting.podspec WorkflowReactiveSwift.podspec WorkflowUI.podspec WorkflowRxSwift.podspec WorkflowReactiveSwiftTesting.podspec WorkflowRxSwiftTesting.podspec WorkflowSwiftUI.podspec WorkflowCombine.podspec WorkflowCombineTesting.podspec ViewEnvironment.podspec
21-
> ```
22-
> And then run a similar command to check the `WorkflowConcurrency*` libraries. These specs will fail default validation as their version differs from the git tag used, so run the command with the `--allow-warnings` option, and check that only that warning is produced.
23-
> ```bash
24-
> bundle exec pod lib lint WorkflowConcurrency.podspec WorkflowConcurrencyTesting.podspec --allow-warnings
20+
> bundle exec pod lib lint Workflow.podspec ViewEnvironment.podspec WorkflowTesting.podspec WorkflowReactiveSwift.podspec WorkflowUI.podspec WorkflowRxSwift.podspec WorkflowReactiveSwiftTesting.podspec WorkflowRxSwiftTesting.podspec WorkflowSwiftUI.podspec WorkflowCombine.podspec WorkflowCombineTesting.podspec WorkflowConcurrency.podspec WorkflowConcurrencyTesting.podspec
2521
> ```
2622
2723
1. Update `VERSION` file based on [`semver`](https://semver.org/).
@@ -48,9 +44,6 @@ For Squares, membership is managed through the `Workflow Swift Owners` registry
4844
bundle exec pod trunk push WorkflowSwiftUI.podspec --synchronous
4945
bundle exec pod trunk push WorkflowCombine.podspec --synchronous
5046
bundle exec pod trunk push WorkflowCombineTesting.podspec --synchronous
51-
52-
# Note: If the following fail due to a validation warning about their version number not matching the git tag,
53-
# it is safe to ignore, and publish anyway by adding the `--allow-warnings` option to the command.
5447
bundle exec pod trunk push WorkflowConcurrency.podspec --synchronous
5548
bundle exec pod trunk push WorkflowConcurrencyTesting.podspec --synchronous
5649
```

WorkflowConcurrency.podspec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ require_relative('version')
22

33
Pod::Spec.new do |s|
44
s.name = 'WorkflowConcurrency'
5-
s.version = WORKFLOW_CONCURRENCY_VERSION
5+
s.version = WORKFLOW_VERSION
66

77
s.summary = 'Infrastructure for Concurrency-powered Workers'
88
s.homepage = 'https://www.github.com/square/workflow-swift'
99
s.license = 'Apache License, Version 2.0'
1010
s.author = 'Square'
11-
s.source = { :git => 'https://github.com/square/workflow-swift.git', :tag => "v#{WORKFLOW_VERSION}" }
11+
s.source = { :git => 'https://github.com/square/workflow-swift.git', :tag => "v#{s.version}" }
1212

1313
# 1.7 is needed for `swift_versions` support
1414
s.cocoapods_version = '>= 1.7.0'
@@ -19,7 +19,7 @@ Pod::Spec.new do |s|
1919

2020
s.source_files = 'WorkflowConcurrency/Sources/*.swift'
2121

22-
s.dependency 'Workflow', "#{WORKFLOW_VERSION}"
22+
s.dependency 'Workflow', "#{s.version}"
2323

2424
s.pod_target_xcconfig = { 'APPLICATION_EXTENSION_API_ONLY' => 'YES' }
2525

WorkflowConcurrencyTesting.podspec

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ require_relative('version')
22

33
Pod::Spec.new do |s|
44
s.name = 'WorkflowConcurrencyTesting'
5-
s.version = WORKFLOW_CONCURRENCY_VERSION
5+
s.version = WORKFLOW_VERSION
66
s.summary = 'Infrastructure for Concurrency-powered Workers'
77
s.homepage = 'https://www.github.com/square/workflow-swift'
88
s.license = 'Apache License, Version 2.0'
99
s.author = 'Square'
10-
s.source = { :git => 'https://github.com/square/workflow-swift.git', :tag => "v#{WORKFLOW_VERSION}" }
10+
s.source = { :git => 'https://github.com/square/workflow-swift.git', :tag => "v#{s.version}" }
1111

1212
# 1.7 is needed for `swift_versions` support
1313
s.cocoapods_version = '>= 1.7.0'
@@ -18,9 +18,9 @@ Pod::Spec.new do |s|
1818

1919
s.source_files = 'WorkflowConcurrency/Testing/**/*.swift'
2020

21-
s.dependency 'Workflow', "#{WORKFLOW_VERSION}"
21+
s.dependency 'Workflow', "#{s.version}"
2222
s.dependency 'WorkflowConcurrency', "#{s.version}"
23-
s.dependency 'WorkflowTesting', "#{WORKFLOW_VERSION}"
23+
s.dependency 'WorkflowTesting', "#{s.version}"
2424

2525
s.framework = 'XCTest'
2626

version.rb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
# frozen_string_literal: true
22

33
# The primary version number for Workflow-related pods
4-
WORKFLOW_VERSION ||= '1.3.1'
5-
6-
# The version number for the WorkflowConcurrency library which
7-
# currently differs from others due to a source-breaking change
8-
# TODO: unify version numbers on next Workflow major release
9-
WORKFLOW_CONCURRENCY_VERSION ||= '2.1.1'
4+
WORKFLOW_VERSION ||= '2.2.0'
105

116
# iOS deployment target
127
WORKFLOW_IOS_DEPLOYMENT_TARGET ||= '14.0'

0 commit comments

Comments
 (0)