Abstract ViewEnvironment to shared framework (#185)

Author: n8chur

Development.podspec

@@ -15,6 +15,7 @@ Pod::Spec.new do |s|
   s.dependency 'WorkflowRxSwift'
   # s.dependency 'WorkflowCombine' # TODO: Disabled because app specs cannot increase the deployment target of the root
   # s.dependency 'WorkflowConcurrency' # TODO: Disabled because app specs cannot increase the deployment target of the root
+  s.dependency 'ViewEnvironment'
 
   s.source_files = 'Samples/Dummy.swift'
 

Package.swift

@@ -75,6 +75,13 @@ let package = Package(
             name: "WorkflowConcurrencyTesting",
             targets: ["WorkflowConcurrencyTesting"]
         ),
+
+        // MARK: ViewEnvironment
+
+        .library(
+            name: "ViewEnvironment",
+            targets: ["ViewEnvironment"]
+        ),
     ],
     dependencies: [
         .package(url: "https://github.com/ReactiveCocoa/ReactiveSwift.git", from: "7.1.1"),
@@ -109,7 +116,7 @@ let package = Package(
 
         .target(
             name: "WorkflowUI",
-            dependencies: ["Workflow"],
+            dependencies: ["Workflow", "ViewEnvironment"],
             path: "WorkflowUI/Sources"
         ),
         .testTarget(
@@ -214,6 +221,13 @@ let package = Package(
             dependencies: ["WorkflowConcurrencyTesting"],
             path: "WorkflowConcurrency/TestingTests"
         ),
+
+        // MARK: ViewEnvironment
+
+        .target(
+            name: "ViewEnvironment",
+            path: "ViewEnvironment/Sources"
+        ),
     ],
     swiftLanguageVersions: [.v5]
 )

RELEASING.md

@@ -17,7 +17,7 @@ For Squares, membership is managed through the `Workflow Swift Owners` registry
 
 > ⚠️ [Optional] To avoid possible headaches when publishing podspecs, validation can be performed before updating the Workflow version number(s). To do this, run the following in the root directory of this repo:
 > ```bash
-> bundle exec pod lib lint Workflow.podspec WorkflowTesting.podspec WorkflowReactiveSwift.podspec WorkflowUI.podspec WorkflowRxSwift.podspec WorkflowReactiveSwiftTesting.podspec WorkflowRxSwiftTesting.podspec WorkflowSwiftUI.podspec WorkflowCombine.podspec WorkflowCombineTesting.podspec
+> bundle exec pod lib lint Workflow.podspec WorkflowTesting.podspec WorkflowReactiveSwift.podspec WorkflowUI.podspec WorkflowRxSwift.podspec WorkflowReactiveSwiftTesting.podspec WorkflowRxSwiftTesting.podspec WorkflowSwiftUI.podspec WorkflowCombine.podspec WorkflowCombineTesting.podspec ViewEnvironment.podspec
 > ```
 > And then run a similar command to check the `WorkflowConcurrency*` libraries. These specs will fail default validation as their version differs from the git tag used, so run the command with the `--allow-warnings` option, and check that only that warning is produced.
 > ```bash
@@ -40,6 +40,7 @@ For Squares, membership is managed through the `Workflow Swift Owners` registry
     bundle exec pod trunk push Workflow.podspec --synchronous
     bundle exec pod trunk push WorkflowTesting.podspec  --synchronous
     bundle exec pod trunk push WorkflowReactiveSwift.podspec --synchronous
+    bundle exec pod trunk push ViewEnvironment.podspec --synchronous
     bundle exec pod trunk push WorkflowUI.podspec --synchronous
     bundle exec pod trunk push WorkflowRxSwift.podspec --synchronous
     bundle exec pod trunk push WorkflowReactiveSwiftTesting.podspec --synchronous

Samples/Tutorial/Podfile

@@ -4,6 +4,7 @@ platform :ios, '11.0'
 target 'Tutorial' do
     pod 'Workflow', path: '../../Workflow.podspec', :testspecs => ['Tests']
     pod 'WorkflowUI', path: '../../WorkflowUI.podspec', :testspecs => ['Tests']
+    pod 'ViewEnvironment', path: '../../ViewEnvironment.podspec'
     pod 'WorkflowReactiveSwift', path: '../../WorkflowReactiveSwift.podspec', :testspecs => ['Tests']
     pod 'BackStackContainer', path: '../BackStackContainer/BackStackContainer.podspec'
 

ViewEnvironment.podspec

@@ -0,0 +1,22 @@
+require_relative('version')
+
+Pod::Spec.new do |s|
+    s.name         = 'ViewEnvironment'
+    s.version      = WORKFLOW_VERSION
+    s.summary      = 'A collection of environment values propagated through a view hierarchy.'
+    s.homepage     = 'https://www.github.com/square/workflow-swift'
+    s.license      = 'Apache License, Version 2.0'
+    s.author       = 'Square'
+    s.source       = { :git => 'https://github.com/square/workflow-swift.git', :tag => "v#{s.version}" }
+
+    # 1.7 is needed for `swift_versions` support
+    s.cocoapods_version = '>= 1.7.0'
+
+    s.swift_versions = ['5.0']
+    s.ios.deployment_target = '11.0'
+    s.osx.deployment_target = '10.13'
+
+    s.source_files = 'ViewEnvironment/Sources/**/*.swift'
+
+    s.pod_target_xcconfig = { 'APPLICATION_EXTENSION_API_ONLY' => 'YES' }
+end

WorkflowUI/Sources/Screen/ViewEnvironment/ViewEnvironment.swift renamed to ViewEnvironment/Sources/ViewEnvironment.swift

@@ -19,6 +19,7 @@ Pod::Spec.new do |s|
     s.source_files = 'WorkflowUI/Sources/**/*.swift'
 
     s.dependency 'Workflow', "#{s.version}"
+    s.dependency 'ViewEnvironment', "#{s.version}"
 
     s.pod_target_xcconfig = { 'APPLICATION_EXTENSION_API_ONLY' => 'YES' }
 

WorkflowUI/Sources/Screen/ViewEnvironment/ViewEnvironmentKey.swift renamed to ViewEnvironment/Sources/ViewEnvironmentKey.swift

@@ -0,0 +1 @@
+@_exported import ViewEnvironment