more pr feedback

jamieQ · jamieQ · commit f92694c77015 · 2023-02-07T08:19:51.000-06:00
diff --git a/Workflow/Sources/WorkflowHost.swift b/Workflow/Sources/WorkflowHost.swift
@@ -36,7 +36,8 @@ public final class WorkflowHost<WorkflowType: Workflow> {
 
     private let (outputEvent, outputEventObserver) = Signal<WorkflowType.Output, Never>.pipe()
 
-    let rootNode: WorkflowNode<WorkflowType>
+    // @testable
+    internal let rootNode: WorkflowNode<WorkflowType>
 
     private let mutableRendering: MutableProperty<WorkflowType.Rendering>
 
diff --git a/Workflow/Tests/WorkflowObserverTests.swift b/Workflow/Tests/WorkflowObserverTests.swift
@@ -44,14 +44,18 @@ final class WorkflowObserverTests: XCTestCase {
             sessionEndedCount += 1
         }
 
+        weak var weakHost: WorkflowHost<StateTransitioningWorkflow>?
+
         // session end happens in deinit, so need control over release timing
         autoreleasepool {
-            _ = WorkflowHost(
+            let host = WorkflowHost(
                 workflow: StateTransitioningWorkflow(),
                 observers: [observer]
             )
+            weakHost = host
         }
 
+        XCTAssertNil(weakHost, "host expected to deallocate")
         XCTAssertNotNil(beganSession)
         XCTAssertNotNil(beganSession?.sessionID)
         XCTAssertEqual(beganSession?.sessionID, endedSession?.sessionID)

Original file line number	Diff line number	Diff line change
`@@ -44,14 +44,18 @@ final class WorkflowObserverTests: XCTestCase {`
`44`	`44`	`sessionEndedCount += 1`
`45`	`45`	`}`
`46`	`46`
	`47`	`+ weak var weakHost: WorkflowHost<StateTransitioningWorkflow>?`
	`48`	`+`
`47`	`49`	`// session end happens in deinit, so need control over release timing`
`48`	`50`	`autoreleasepool {`
`49`		`- _ = WorkflowHost(`
	`51`	`+ let host = WorkflowHost(`
`50`	`52`	`workflow: StateTransitioningWorkflow(),`
`51`	`53`	`observers: [observer]`
`52`	`54`	`)`
	`55`	`+ weakHost = host`
`53`	`56`	`}`
`54`	`57`
	`58`	`+ XCTAssertNil(weakHost, "host expected to deallocate")`
`55`	`59`	`XCTAssertNotNil(beganSession)`
`56`	`60`	`XCTAssertNotNil(beganSession?.sessionID)`
`57`	`61`	`XCTAssertEqual(beganSession?.sessionID, endedSession?.sessionID)`