Fixed broken kdoc links and some other warnings. #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added configuration to generate dokka output for some modules.
zach-klippenstein
force-pushed
the
zachklipp/fix-kdoc
branch
from
04ec307 to
d718aa1
Compare
zach-klippenstein
changed the title
rjrjr
approved these changes
Mar 29, 2019
| * | ||
| * **Never call [Workflow.compose] directly, always do it through this context method.** | ||
| * **Never call [StatefulWorkflow.compose] or [StatelessWorkflow.compose] directly, always do it | ||
| * through this context method.** | ||
| * | ||
| * 1. If the child _wasn't_ already running, it will be started either from | ||
| * [initialState][Workflow.initialState] or its snapshot. |
There was a problem hiding this comment.
nit: no longer really an or situation, since we unified the methods.
There was a problem hiding this comment.
Those are still related though, and I want to avoid confusion about people trying to call them directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added configuration to generate dokka output for some modules.