Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add teardown hook on WorkflowContext. #233

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Add teardown hook on WorkflowContext. #233

merged 1 commit into from
Mar 29, 2019

Conversation

zach-klippenstein
Copy link
Collaborator

Closes #231.

@zach-klippenstein zach-klippenstein added this to the v0.11.0 milestone Mar 29, 2019
rjrjr
rjrjr approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@rjrjr rjrjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So clean.

kotlin/workflow-core/src/main/java/com/squareup/workflow/WorkflowContext.kt Outdated
/**
* Adds an action to be invoked if the workflow is discarded by its parent before the next
* compose pass. Multiple hooks can be registered in the same compose pass, they will be invoked
* in the same order they're set. Hooks are cleared at the start of each compose pass, so you must
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like any other work performed through the context (e.g. calls to [compose] or [onSuccess]), hooks are cleared…

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@zach-klippenstein zach-klippenstein merged commit 99ab6eb into master Mar 29, 2019
@zach-klippenstein zach-klippenstein deleted the zachklipp/teardown branch March 29, 2019 17:39
@zach-klippenstein zach-klippenstein added the kotlin Affects the Kotlin library. label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjrjr rjrjr rjrjr approved these changes

@timdonnelly timdonnelly Awaiting requested review from timdonnelly

@Blisse Blisse Awaiting requested review from Blisse

@davidapgar davidapgar Awaiting requested review from davidapgar

@grantamos grantamos Awaiting requested review from grantamos

@steveinflow steveinflow Awaiting requested review from steveinflow

Assignees
No one assigned
Labels
kotlin Affects the Kotlin library.
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Add teardown hook to WorkflowContext
2 participants
@zach-klippenstein @rjrjr