Renames ui modules to workflow-ui-core, workflow-ui-android. #239
Conversation
| import com.squareup.workflow.ui.ViewBinding | ||
| import com.squareup.workflow.ui.ViewRegistry | ||
| import com.squareup.workflow.ui.backstack.ViewStateStack.Direction | ||
| import com.squareup.workflow.ui.buildScene |
There was a problem hiding this comment.
Is com.squareup.workflow.ui.android.* too long a package name? It would be nice if the package names corresponded to the module names.
There was a problem hiding this comment.
Not so much that it's too long as that it's kind of an orthogonal concern, kind of redundant. Is that extra package name really useful to the android developer, or would it be cognitive clutter?
I did the same thing in the sample code -- the coordinators in the android module are in the same packages as the related screen objects in the common module.
WDYT?
There was a problem hiding this comment.
I'll merge this as-is, and follow up if you feel strongly.
There was a problem hiding this comment.
Yea, I don't feel strongly. And if you're writing a UI for non-android, you're not going to depend on both android and javafx (e.g.) artifacts anyway.
kotlin/workflow-ui-android/src/main/java/com/squareup/workflow/ui/backstack/NoEffect.kt
Outdated
Show resolved
Hide resolved
`WorkflowHost` is the name of the class that is the entrypoint to the runtime, but this module actually contains the entire runtime implementation, and so I think it's a more accurate name. Inspired by #239.
|
You've inspired me to do #240. |
rjrjr
force-pushed
the
ray/android-workflow-ui
branch
from
e7f3c44 to
b0d125e
Compare
rjrjr
force-pushed
the
ray/android-workflow-ui
branch
from
b0d125e to
6dc9967
Compare
|
Updates made unintentional reformat intentional / better, and rebased to keep up w/master |
No description provided.