Fixed bug #1421 : Ternaries used in constant scalar expression for param default misidentified by tokenizer

Author: gsherwood

CodeSniffer/Standards/Squiz/Tests/WhiteSpace/OperatorSpacingUnitTest.inc

@@ -187,3 +187,5 @@ $username = $_GET['user']??'nobody';
 function foo(string $bar, array $baz, ?MyClass $object) : MyClass {}
 
 declare(strict_types=1);
+
+function foo($c = ((BAR)?10:100)) {}

CodeSniffer/Standards/Squiz/Tests/WhiteSpace/OperatorSpacingUnitTest.inc.fixed

@@ -181,3 +181,5 @@ $username = $_GET['user'] ?? 'nobody';
 function foo(string $bar, array $baz, ?MyClass $object) : MyClass {}
 
 declare(strict_types=1);
+
+function foo($c = ((BAR) ? 10 : 100)) {}

CodeSniffer/Standards/Squiz/Tests/WhiteSpace/OperatorSpacingUnitTest.php

@@ -104,6 +104,7 @@ public function getErrorList($testFile='OperatorSpacingUnitTest.inc')
                     178 => 1,
                     179 => 1,
                     185 => 2,
+                    191 => 4,
                    );
             break;
         case 'OperatorSpacingUnitTest.js':

CodeSniffer/Tokenizers/PHP.php

@@ -733,7 +733,7 @@ public function tokenizeString($string, $eolChar='\n')
                         $newToken['code'] = T_NULLABLE;
                         $newToken['type'] = 'T_NULLABLE';
                         break;
-                    } else if (in_array($tokenType, array(T_OPEN_TAG, T_OPEN_TAG_WITH_ECHO, '{', ';')) === true) {
+                    } else if (in_array($tokenType, array(T_OPEN_TAG, T_OPEN_TAG_WITH_ECHO, '=', '{', ';')) === true) {
                         $newToken['code'] = T_INLINE_THEN;
                         $newToken['type'] = 'T_INLINE_THEN';
 

package.xml

@@ -57,6 +57,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
   - Fixed bug #1394 : integer type hints appearing as TypeHintMissing instead of ScalarTypeHintMissing
     -- PHP 7 type hints were also being shown when run under PHP 5 in some cases
   - Fixed bug #1405 : Squiz.WhiteSpace.ScopeClosingBrace fails to fix closing brace within indented PHP tags
+  - Fixed bug #1421 : Ternaries used in constant scalar expression for param default misidentified by tokenizer
  </notes>
  <contents>
   <dir name="/">