False positive for function names starting with triple underscore #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any function and method names starting with a double underscore are reserved by PHP itself for magic functions/methods. A triple underscore function name prefix, however, should not trigger an error. (not saying it's a good idea, but it's out there in userland code) Fixed in the two non-proprietary standards which have checks for double underscored function/method names. Includes additional unit tests for all four sniffs. This PR does not cover similar checks in the proprietary PEAR and Squiz standards.
|
Your code also does cover cases when 3+ (not just exactly 3) underscores are used. |
Correct, it does. |
gsherwood
changed the title
gsherwood
added a commit
that referenced
this pull request
Dec 15, 2016
|
Thanks for the fix. I also ended up fixing it in the PEAR and Squiz standards because they were trying to do the same thing. |
|
@gsherwood You're welcome ;-) |
|
P.S.: I did originally also add it for the PEAR and Squiz standards (locally), but ended up removing it as the unit tests I added for it were triggering the CamelCase rules for those sniffs, so no matter what, the function name would end up not being acceptable. |
photodude
added a commit
to photodude/coding-standards
that referenced
this pull request
Feb 19, 2017
photodude
added a commit
to photodude/coding-standards
that referenced
this pull request
Mar 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function and method names starting with a double underscore are reserved by PHP itself for magic functions/methods.
A triple underscore function name prefix, however, should not trigger this error. (I'm not saying it's a good idea, but it's out there in userland code)
Fixed in the two non-proprietary standards which have checks for double underscored function/method names.
Includes additional unit tests for all four sniffs.
This PR does not cover similar checks in the proprietary PEAR and Squiz standards.
Fixes PHPCompatibility/PHPCompatibility#297