Skip to content

Commit a3aaa7b

Browse files
fix: Added changes to fix the lcov issue (twilio#170)
* fix: Added the changes for lcov * Update package.json
1 parent d971661 commit a3aaa7b

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

.github/workflows/cli-core-test.yml

+5-9
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ jobs:
1414
steps:
1515
- name: Checkout cli core repo
1616
uses: actions/checkout@v2
17+
with:
18+
# Disabling shallow clone is recommended for improving relevancy of reporting
19+
fetch-depth: 0
1720
- run: npm install
1821
- name: Use Node.js ${{ matrix.node-version }}
1922
uses: actions/setup-node@v2
@@ -22,21 +25,14 @@ jobs:
2225
cache: 'npm'
2326
- name: Run tests
2427
run: npm test
25-
sonarcloud:
26-
runs-on: ubuntu-latest
27-
steps:
28-
- uses: actions/checkout@v2
29-
with:
30-
# Disabling shallow clone is recommended for improving relevancy of reporting
31-
fetch-depth: 0
3228
- name: SonarCloud Scan
3329
uses: sonarsource/sonarcloud-github-action@master
3430
env:
3531
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3632
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
3733
notify-complete-fail:
38-
if: ${{ failure() || cancelled() }}
39-
needs: [ test, sonarcloud ]
34+
if: ${{ failure() && github.ref == 'refs/heads/main' && github.event_name != 'pull_request' }}
35+
needs: [ test ]
4036
name: Notify Test Failed
4137
runs-on: ubuntu-latest
4238
steps:

0 commit comments

Comments
 (0)