Skip to content

Commit 336ad46

Browse files
committed
tests: make regression tests use squash rule
Signed-off-by: Miguel Molina <[email protected]>
1 parent 50061f6 commit 336ad46

File tree

1 file changed

+22
-15
lines changed

1 file changed

+22
-15
lines changed

Diff for: regression_test.go

+22-15
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,15 @@ package gitbase_test
22

33
import (
44
"context"
5+
"fmt"
56
"io/ioutil"
67
"os"
78
"testing"
89

910
"github.com/src-d/gitbase"
10-
"github.com/stretchr/testify/require"
1111
"github.com/src-d/go-mysql-server/sql"
1212
"github.com/src-d/go-mysql-server/sql/index/pilosa"
13+
"github.com/stretchr/testify/require"
1314
yaml "gopkg.in/yaml.v2"
1415
)
1516

@@ -20,13 +21,12 @@ type Query struct {
2021
}
2122

2223
func TestRegressionQueries(t *testing.T) {
23-
require := require.New(t)
24-
25-
engine, pool, cleanup := setup(t)
24+
_, pool, cleanup := setup(t)
2625
defer cleanup()
2726

27+
engine := newSquashEngine(pool)
2828
tmpDir, err := ioutil.TempDir(os.TempDir(), "pilosa-idx-gitbase")
29-
require.NoError(err)
29+
require.NoError(t, err)
3030
defer os.RemoveAll(tmpDir)
3131
engine.Catalog.RegisterIndexDriver(pilosa.NewDriver(tmpDir))
3232

@@ -36,20 +36,27 @@ func TestRegressionQueries(t *testing.T) {
3636
)
3737

3838
queries, err := loadQueriesYaml("./_testdata/regression.yml")
39-
require.NoError(err)
39+
require.NoError(t, err)
4040

4141
for _, q := range queries {
42-
for _, stmt := range q.Statements {
43-
_, iter, err := engine.Query(ctx, stmt)
44-
if err != nil {
45-
require.Failf(err.Error(), "ID: %s, Name: %s, Statement: %s", q.ID, q.Name, stmt)
46-
}
42+
t.Run(q.ID, func(t *testing.T) {
43+
require := require.New(t)
44+
for _, stmt := range q.Statements {
45+
_, iter, err := engine.Query(ctx, stmt)
46+
if err != nil {
47+
require.Failf(err.Error(), "ID: %s, Name: %s, Statement: %s", q.ID, q.Name, stmt)
48+
}
49+
50+
rows, err := sql.RowIterToRows(iter)
51+
if err != nil {
52+
require.Failf(err.Error(), "ID: %s, Name: %s, Statement: %s", q.ID, q.Name, stmt)
53+
}
4754

48-
_, err = sql.RowIterToRows(iter)
49-
if err != nil {
50-
require.Failf(err.Error(), "ID: %s, Name: %s, Statement: %s", q.ID, q.Name, stmt)
55+
for _, row := range rows {
56+
fmt.Println(row)
57+
}
5158
}
52-
}
59+
})
5360
}
5461
}
5562

0 commit comments

Comments
 (0)