Skip to content

Commit 484190e

Browse files
committed
Remove macOS builds, say thanks to M1's arm64 + x86-64 hybrid compilation
Signed-off-by: Vadim Markovtsev <[email protected]>
1 parent fbdcc07 commit 484190e

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

.github/workflows/push.yml

+7-11
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,16 @@ jobs:
1616
flake8:
1717
name: flake8
1818
if: "!contains(github.event.head_commit.message, 'Bump version')"
19-
runs-on: ubuntu-20.04
19+
runs-on: ubuntu-22.04
2020
steps:
2121
- name: actions/checkout
2222
uses: actions/checkout@v2
2323
- name: actions/cache
2424
uses: actions/cache@v2
2525
with:
2626
path: ${{ env.PIP_CACHE }}
27-
key: ubuntu-20.04-pip-lint-${{ hashFiles('lint-requirements.txt') }}
28-
restore-keys: ubuntu-20.04-pip-lint-
27+
key: ubuntu-22.04-pip-lint-${{ hashFiles('lint-requirements.txt') }}
28+
restore-keys: ubuntu-22.04-pip-lint-
2929
- name: pip lint-requirements.txt
3030
run: |
3131
set -x
@@ -42,7 +42,7 @@ jobs:
4242
strategy:
4343
fail-fast: false
4444
matrix:
45-
os: [ ubuntu-latest, macos-latest, windows-latest ]
45+
os: [ ubuntu-latest, windows-latest ]
4646
cibw_python: [ "cp38-*", "cp39-*", "cp310-*" ]
4747
cibw_arch: [ "auto64" ]
4848

@@ -57,8 +57,8 @@ jobs:
5757
uses: actions/cache@v2
5858
with:
5959
path: ${{ env.PIP_CACHE }}
60-
key: ubuntu-20.04-pip-main-${{ hashFiles('requirements.txt', 'test-requirements.txt') }}
61-
restore-keys: ubuntu-20.04-pip-main-
60+
key: ubuntu-22.04-pip-main-${{ hashFiles('requirements.txt', 'test-requirements.txt') }}
61+
restore-keys: ubuntu-22.04-pip-main-
6262
- name: pip requirements.txt
6363
run: |
6464
set -x
@@ -69,16 +69,12 @@ jobs:
6969
- name: test
7070
run: |
7171
set -x
72-
if [ "${{ matrix.os }}" == "macos-latest" ]; then
73-
sysctl -a
74-
(sysctl -a | grep machdep.cpu.leaf7_features | grep AVX2) || exit 0
75-
fi
7672
python3 -m unittest discover .
7773
bump_version:
7874
name: Bump the version
7975
needs: [ flake8, test ]
8076
if: "!contains(github.event.head_commit.message, 'Bump version') && github.ref == 'refs/heads/master'"
81-
runs-on: ubuntu-20.04
77+
runs-on: ubuntu-22.04
8278
steps:
8379
- name: actions/checkout
8480
uses: actions/checkout@v2

README.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ Installing
3636
```
3737
pip3 install lapjv
3838
```
39-
Tested on Linux and macOS.
39+
Tested on Linux and Windows. *macOS is not supported, please do not report macOS build errors in the issues.*
40+
Feel free to PR macOS support, but I warn that it will be a rough ride.
4041

4142
Usage
4243
-----

setup.py

+7-4
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@
33

44
from setuptools import Extension, setup
55

6-
# GCP N2
7-
GCC_OPT = [
6+
UNIX_CXXFLAGS = [
7+
"-std=c++17",
8+
"-mavx2",
9+
"-ftree-vectorize",
10+
# GCP N2
811
"-march=haswell",
912
"-maes",
1013
"-mno-pku",
@@ -15,8 +18,8 @@
1518
]
1619

1720
CXX_ARGS = {
18-
"Darwin": ["-std=c++17", *GCC_OPT, "-mavx2", "-ftree-vectorize"],
19-
"Linux": ["-fopenmp", "-std=c++17", *GCC_OPT, "-mabm", "-mavx2", "-ftree-vectorize"],
21+
# "Darwin": [*UNIX_CXXFLAGS], not supported anymore due to M1, PRs welcome
22+
"Linux": ["-fopenmp", *UNIX_CXXFLAGS, "-mabm"],
2023
"Windows": ["/openmp", "/std:c++latest", "/arch:AVX2"],
2124
}
2225

test-requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
scipy==1.8.0
1+
scipy==1.9.3

0 commit comments

Comments
 (0)