Skip to content

Issue with removing #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Di4ik3r opened this issue Apr 24, 2020 · 1 comment
Open

Issue with removing #1

Di4ik3r opened this issue Apr 24, 2020 · 1 comment

Comments

@Di4ik3r
Copy link

Di4ik3r commented Apr 24, 2020

I am trying to use this tree, and found a bug: when 'remove' function is calling itself in "node.left && node.right" condition, its not called with parent and side parameters, which is causing cloning of value (perhaps its not removing value).
Here is situation where i had faced it and how i solved issue: https://imgur.com/a/56E71p5
btw, lib and code is great so far

@ssp5zone
Copy link
Owner

@Di4ik3r Thanks for pointing this out. Will fix this. I have added you as a collab, if you could create a Pull that would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants