diff --git a/crates/stackable-operator/CHANGELOG.md b/crates/stackable-operator/CHANGELOG.md index 8c5dcb8f5..2de9d7aab 100644 --- a/crates/stackable-operator/CHANGELOG.md +++ b/crates/stackable-operator/CHANGELOG.md @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file. ## [Unreleased] +### Removed + +- Remove instrumenation from uninteresting funtions ([#1023]). + +[#1023]: https://github.com/stackabletech/operator-rs/pull/1023 + ## [0.93.1] - 2025-05-20 ### Added @@ -23,6 +29,7 @@ All notable changes to this project will be documented in this file. - Import are now more granular in general. - BREAKING: Update to `kube` to `1.0.0` and `k8s-openapi` to `0.25.0`. Use k8s `1.33` for compilation ([#1037]). +- Separate some developer docs from CRD descriptions ([#1040]). ### Fixed @@ -33,6 +40,7 @@ All notable changes to this project will be documented in this file. [#1025]: https://github.com/stackabletech/operator-rs/pull/1025 [#1029]: https://github.com/stackabletech/operator-rs/pull/1029 [#1037]: https://github.com/stackabletech/operator-rs/pull/1037 +[#1040]: https://github.com/stackabletech/operator-rs/pull/1040 ## [0.92.0] - 2025-04-14 diff --git a/crates/stackable-operator/src/builder/pod/container.rs b/crates/stackable-operator/src/builder/pod/container.rs index bf66dfd78..ea9631782 100644 --- a/crates/stackable-operator/src/builder/pod/container.rs +++ b/crates/stackable-operator/src/builder/pod/container.rs @@ -7,7 +7,6 @@ use k8s_openapi::api::core::v1::{ SecurityContext, VolumeMount, }; use snafu::{ResultExt as _, Snafu}; -use tracing::instrument; #[cfg(doc)] use {k8s_openapi::api::core::v1::PodSpec, std::collections::BTreeMap}; @@ -211,7 +210,6 @@ impl ContainerBuilder { /// /// Previously, this function unconditionally added [`VolumeMount`]s, which resulted in invalid /// [`PodSpec`]s. - #[instrument(skip(self))] fn add_volume_mount_impl(&mut self, volume_mount: VolumeMount) -> Result<&mut Self> { if let Some(existing_volume_mount) = self.volume_mounts.get(&volume_mount.mount_path) { if existing_volume_mount != &volume_mount { diff --git a/crates/stackable-operator/src/builder/pod/mod.rs b/crates/stackable-operator/src/builder/pod/mod.rs index 03aab690b..197a8517b 100644 --- a/crates/stackable-operator/src/builder/pod/mod.rs +++ b/crates/stackable-operator/src/builder/pod/mod.rs @@ -10,7 +10,6 @@ use k8s_openapi::{ apimachinery::pkg::{api::resource::Quantity, apis::meta::v1::ObjectMeta}, }; use snafu::{OptionExt, ResultExt, Snafu}; -use tracing::{instrument, warn}; use crate::{ builder::{ @@ -291,7 +290,6 @@ impl PodBuilder { /// /// Previously, this function unconditionally added [`Volume`]s, which resulted in invalid /// [`PodSpec`]s. - #[instrument(skip(self))] pub fn add_volume(&mut self, volume: Volume) -> Result<&mut Self> { if let Some(existing_volume) = self.volumes.get(&volume.name) { if existing_volume != &volume { @@ -610,19 +608,19 @@ impl PodBuilder { pod_spec .check_resource_requirement(ResourceRequirementsType::Limits, "cpu") - .unwrap_or_else(|err| warn!("{}", err)); + .unwrap_or_else(|err| tracing::warn!("{err}")); pod_spec .check_resource_requirement(ResourceRequirementsType::Limits, "memory") - .unwrap_or_else(|err| warn!("{}", err)); + .unwrap_or_else(|err| tracing::warn!("{err}")); pod_spec .check_limit_to_request_ratio(&ComputeResource::Cpu, LIMIT_REQUEST_RATIO_CPU) - .unwrap_or_else(|err| warn!("{}", err)); + .unwrap_or_else(|err| tracing::warn!("{err}")); pod_spec .check_limit_to_request_ratio(&ComputeResource::Memory, LIMIT_REQUEST_RATIO_MEMORY) - .unwrap_or_else(|err| warn!("{}", err)); + .unwrap_or_else(|err| tracing::warn!("{err}")); pod_spec }