From 836bd80a5a117e59428818b9b9900fb4cece4825 Mon Sep 17 00:00:00 2001
From: Siegfried Weber <mail@siegfriedweber.net>
Date: Tue, 24 Sep 2024 12:58:17 +0200
Subject: [PATCH] fix: Logback configuration

---
 crates/stackable-operator/CHANGELOG.md             |  7 +++++++
 .../src/product_logging/framework.rs               | 14 +++++++++++++-
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/crates/stackable-operator/CHANGELOG.md b/crates/stackable-operator/CHANGELOG.md
index 83a197b50..921aa57f0 100644
--- a/crates/stackable-operator/CHANGELOG.md
+++ b/crates/stackable-operator/CHANGELOG.md
@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
+### Fixed
+
+- Fix the logback configuration for logback versions from 1.3.6/1.4.6 to
+  1.3.11/1.4.11 ([#874]).
+
+[#874]: https://github.com/stackabletech/operator-rs/pull/874
+
 ## [0.76.0] - 2024-09-19
 
 ### Added
diff --git a/crates/stackable-operator/src/product_logging/framework.rs b/crates/stackable-operator/src/product_logging/framework.rs
index d9de94672..7913e9e2b 100644
--- a/crates/stackable-operator/src/product_logging/framework.rs
+++ b/crates/stackable-operator/src/product_logging/framework.rs
@@ -589,7 +589,19 @@ pub fn create_logback_config(
     </rollingPolicy>
     <triggeringPolicy class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy">
       <MaxFileSize>{max_log_file_size_in_mib}MB</MaxFileSize>
-      <checkIncrement>5 seconds</checkIncrement>
+      <!--
+        checkIncrement defines how often file sizes are checked, because
+        checking them is a relatively costly operation.
+        checkIncrement was introduced in the SizeBasedTriggeringPolicy in
+        logback 1.3.6/1.4.6 as an Integer representing milliseconds. In logback
+        1.3.12/1.4.12, it was changed to a Duration, also accepting a unit.
+        Without a given unit, milliseconds are assumed. The logback manual is
+        misleading: In logback 1.5.8, checkIncrement is no longer used for the
+        SizeAndTimeBasedFileNamingAndTriggeringPolicy, but it is still used for
+        the SizeBasedTriggeringPolicy!
+        In prior versions of logback, setting this option has no effect.
+      -->
+      <checkIncrement>5000</checkIncrement>
     </triggeringPolicy>
   </appender>