Skip to content

Lots of optional properties shouldn't be optional #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fhennig opened this issue Dec 11, 2023 · 2 comments · Fixed by #319
Closed

Lots of optional properties shouldn't be optional #320

fhennig opened this issue Dec 11, 2023 · 2 comments · Fixed by #319
Assignees
@adwk67 @sbernauer
Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.

Comments

@fhennig
Copy link
Contributor

fhennig commented Dec 11, 2023

I see that almost all SparkApplication properties are Optional, and at least some of them are actually required and cause an error if they are missing. For example the main_application_file.

Potential fix: make the required properties actually mandatory and not optional.
@fhennig fhennig mentioned this issue Dec 11, 2023
Merged
@adwk67 adwk67 moved this to Development: In Progress in Stackable Engineering Dec 12, 2023
@adwk67 adwk67 self-assigned this Dec 12, 2023
@adwk67 adwk67 linked a pull request Dec 12, 2023 that will close this issue
feat: Better CRD docs #319
Merged
@adwk67 adwk67 moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Dec 12, 2023
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Dec 13, 2023
@sbernauer sbernauer self-assigned this Dec 13, 2023
@adwk67 adwk67 changed the title Lot's of optional properties shouldn't be optional Lots of optional properties shouldn't be optional Dec 13, 2023
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Dec 14, 2023
@lfrancke
Copy link
Member

Is this a breaking change and is it a CRD change?

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Dec 21, 2023
@adwk67
Copy link
Member

adwk67 commented Dec 21, 2023

Technically breaking, but not so in practice. From the changelog:

Removed version field. Several attributes have been changed to mandatory. While this change is
technically breaking, existing Spark jobs would not have worked before as these attributes were necessary

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Dec 21, 2023
@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adwk67 adwk67

@sbernauer sbernauer

Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Better CRD docs stackabletech/spark-k8s-operator
4 participants
@lfrancke @adwk67 @fhennig @sbernauer