Reworking tests for more readability and better codes style

Author: Maleware

tests/templates/kuttl/smoke/31-assert.yaml

@@ -7,9 +7,30 @@ commands:
   # Test envOverrides
   #
   - script: |
-      kubectl -n $NAMESPACE get cm superset-node-default -o yaml | yq -e '.data."superset_config.py"' | grep "COMMON_HEADER_VAR = "group-value""
-      kubectl -n $NAMESPACE get cm superset-node-default -o yaml | yq -e '.data."superset_config.py"' | grep "ROLE_FOOTER_VAR = "role-value""
-      if [ -z "$(kubectl -n $NAMESPACE get cm superset-node-default -o yaml | yq -e '.data."superset_config.py"' | grep "ROLE_HEADER_VAR = \"role-value\"")" ]; then (echo "Success, ROLE_HEADER_VAR not present") else { echo "Failure, ROLE_HEADER_VAR present"; exit 1; } fi
-      kubectl -n $NAMESPACE get sts superset-node-default -o yaml | yq -e '.spec.template.spec.containers[] | select (.name == "superset") | .env[] | select (.name == "COMMON_VAR" and .value == "group-value")'
-      kubectl -n $NAMESPACE get sts superset-node-default -o yaml | yq -e '.spec.template.spec.containers[] | select (.name == "superset") | .env[] | select (.name == "GROUP_VAR" and .value == "group-value")'
-      kubectl -n $NAMESPACE get sts superset-node-default -o yaml | yq -e '.spec.template.spec.containers[] | select (.name == "superset") | .env[] | select (.name == "ROLE_VAR" and .value == "role-value")'
+      #!/usr/bin/env bash
+      set -euo pipefail
+
+      # Config Test Data
+      SUPERSET_CONFIG=$(
+          kubectl -n "$NAMESPACE" get cm superset-node-default -o yaml \
+          | yq -e '.data["superset_config.py"]'
+      )
+
+      # Config Test Assertions
+      echo "$SUPERSET_CONFIG" | grep 'COMMON_HEADER_VAR = "group-value"'
+      echo "$SUPERSET_CONFIG" | grep 'ROLE_FOOTER_VAR = "role-value"'
+      echo "$SUPERSET_CONFIG" | grep -v 'ROLE_HEADER_VAR = "role-value"'
+
+      # STS Spec Test Data
+      SUPERSET_NODE_DEFAULT_STS=$(kubectl -n "$NAMESPACE" get sts superset-node-default -o yaml)
+      YQ_FILTER='
+        .spec.template.spec.containers[]
+        | select(.name == "superset")
+        | .env[]
+        | select(.name == strenv(KEY) and .value == strenv(VALUE))
+      '
+
+      # STS Spec Test Assertions
+      echo "$SUPERSET_NODE_DEFAULT_STS" | KEY="COMMON_VAR" VALUE="group-value" yq -e "$YQ_FILTER"
+      echo "$SUPERSET_NODE_DEFAULT_STS" | KEY="GROUP_VAR" VALUE="group-value" yq -e "$YQ_FILTER"
+      echo "$SUPERSET_NODE_DEFAULT_STS" | KEY="ROLE_VAR" VALUE="role-value" yq -e "$YQ_FILTER"