fix_: create/restore account error signal (#6174)

* fix_: publish node.login signal with error

* test_: use node.login signal instead of node.ready

Author: igor-sirotin

mobile/status.go

@@ -531,7 +531,7 @@ func createAccountAndLogin(requestJSON string) string {
 		_, err := statusBackend.CreateAccountAndLogin(&request)
 		if err != nil {
 			logutils.ZapLogger().Error("failed to create account", zap.Error(err))
-			return err
+			return statusBackend.LoggedIn("", err)
 		}
 		logutils.ZapLogger().Debug("started a node, and created account")
 		return nil
@@ -603,7 +603,7 @@ func restoreAccountAndLogin(requestJSON string) string {
 
 		if err != nil {
 			logutils.ZapLogger().Error("failed to restore account", zap.Error(err))
-			return err
+			return statusBackend.LoggedIn("", err)
 		}
 		logutils.ZapLogger().Debug("started a node, and restored account")
 		return nil

tests-functional/clients/signals.py

@@ -87,6 +87,12 @@ def wait_for_signal(self, signal_type, timeout=20):
             return self.received_signals[signal_type]["received"][-1]
         return self.received_signals[signal_type]["received"][-delta_count:]
 
+    def wait_for_login(self):
+        signal = self.wait_for_signal(SignalType.NODE_LOGIN.value)
+        if "error" in signal["event"]:
+            assert not signal["event"]["error"]
+        return signal
+
     def find_signal_containing_pattern(self, signal_type, event_pattern, timeout=20):
         start_time = time.time()
         while True:

tests-functional/clients/status_backend.py

@@ -64,6 +64,9 @@ def init_status_backend(self, data_dir="/"):
         method = "InitializeApplication"
         data = {
             "dataDir": data_dir,
+            "logEnabled": True,
+            "logLevel": "DEBUG",
+            "apiLogging": True,
         }
         return self.api_valid_request(method, data)
 
@@ -76,7 +79,7 @@ def create_account_and_login(self, data_dir="/", display_name=DEFAULT_DISPLAY_NA
             "password": password,
             "customizationColor": "primary",
             "logEnabled": True,
-            "logLevel": "INFO",
+            "logLevel": "DEBUG",
         }
         return self.api_valid_request(method, data)
 
@@ -90,7 +93,7 @@ def restore_account_and_login(self, data_dir="/",display_name=DEFAULT_DISPLAY_NA
             "mnemonic": user.passphrase,
             "customizationColor": "blue",
             "logEnabled": True,
-            "logLevel": "INFO",
+            "logLevel": "DEBUG",
             "testNetworksEnabled": True,
             "networkId": 31337,
             "networksOverride": [

tests-functional/tests/test_cases.py

@@ -25,15 +25,15 @@ def setup_method(self):
 class StatusBackendTestCase:
 
     await_signals = [
-        SignalType.NODE_READY.value
+        SignalType.NODE_LOGIN.value
     ]
 
     def setup_class(self):
         self.rpc_client = StatusBackend(await_signals=self.await_signals)
 
         self.rpc_client.init_status_backend()
         self.rpc_client.restore_account_and_login()
-        self.rpc_client.wait_for_signal(SignalType.NODE_READY.value)
+        self.rpc_client.wait_for_login()
 
         self.network_id = 31337
 

tests-functional/tests/test_init_status_app.py

@@ -30,7 +30,7 @@ def test_init_app(self):
         backend_client.verify_json_schema(
             backend_client.wait_for_signal(SignalType.NODE_READY.value), "signal_node_ready")
         backend_client.verify_json_schema(
-            backend_client.wait_for_signal(SignalType.NODE_LOGIN.value), "signal_node_login")
+            backend_client.wait_for_login(), "signal_node_login")
 
 
 @pytest.mark.rpc