Update to golangci-lint 1.8.1. Get rid of standalong misspell linter.

Author: Pedro Pombeiro

.golangci.yml

@@ -6,6 +6,8 @@ run:
   # build-tags:
   #   - mytag
   skip-dirs:
+    - lib/* # Can't run linter govet: can't run govet on source packages: can't read "lib/C": open lib/C: no such file ordirector
+    - signal/* # Can't run linter govet: can't run govet on source packages: can't read "signal/C": open signal/C: no such file ordirector
     - static
   skip-files:
     - .*_mock.go
@@ -56,16 +58,16 @@ linters:
     - ineffassign
     - interfacer
     - megacheck
-    #- misspell
+    - misspell
     - structcheck
     - typecheck
     - unconvert
     - varcheck
   fast: false
 
-# issues:
-#   exclude:
-#     - abcdef
+issues:
+  exclude:
+    - "composite literal uses unkeyed fields" # govet
 #   exclude-use-default: true
 #   max-per-linter: 0
 #   max-same: 0

Makefile

@@ -195,14 +195,12 @@ test-e2e-race: gotest_extraflags=-race
 test-e2e-race: test-e2e ##@tests Run e2e tests with -race flag
 
 lint-install:
-	go get -u github.com/client9/misspell/cmd/misspell
 	@# The following installs a specific version of golangci-lint, which is appropriate for a CI server to avoid different results from build to build
-	curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b $(GOPATH)/bin v1.6.1
+	curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b $(GOPATH)/bin v1.8.1
 
 lint:
 	@echo "lint"
 	@golangci-lint run ./...
-	@find . -type f -not -path "./.ethereumtest/*" -not -path "./vendor/*" -not -path "./extkeys/mnemonic.go" -not -path "./extkeys/mnemonic_vectors.json" -print0 | xargs -0 misspell
 
 ci: lint mock dep-ensure test-unit test-e2e ##@tests Run all linters and tests at once