(fix) modify disclaimer component for on tap UX

Author: siddarthkay

src/quo2/components/selectors/disclaimer/component_spec.cljs

@@ -12,12 +12,6 @@
       (h/render [disclaimer/view {} text])
       (h/is-truthy (h/get-by-text text))))
 
-  (h/test "On change event gets fire after press"
-    (let [mock-fn (h/mock-fn)]
-      (h/render [disclaimer/view {:on-change mock-fn} "test"])
-      (h/fire-event :press (h/get-by-label-text :checkbox-off))
-      (h/was-called mock-fn)))
-
   (h/describe "It's rendered according to its `checked?` property"
     (h/test "checked? true"
       (h/render [disclaimer/view {:checked? true} "test"])

src/quo2/components/selectors/disclaimer/view.cljs

@@ -2,18 +2,23 @@
   (:require [quo2.components.markdown.text :as text]
             [quo2.components.selectors.disclaimer.style :as style]
             [quo2.components.selectors.selectors.view :as selectors]
-            [react-native.core :as rn]))
+            [react-native.core :as rn]
+            [reagent.core :as reagent]))
 
 (defn view
-  [{:keys [checked? blur? on-change accessibility-label container-style]} label]
-  [rn/view
-   {:style (merge container-style (style/container blur?))}
-   [selectors/checkbox
-    {:accessibility-label accessibility-label
-     :blur?               blur?
-     :checked?            checked?
-     :on-change           on-change}]
-   [text/text
-    {:size  :paragraph-2
-     :style style/text}
-    label]])
+  [{:keys [checked? blur? accessibility-label container-style]} label]
+  (let [checked-state? (reagent/atom (or checked? false))]
+    (fn []
+      [rn/touchable-opacity
+       {:on-press            #(swap! checked-state? not)
+        :accessibility-label "disclaimer-touchable-opacity"}
+       [rn/view {:style (merge container-style (style/container blur?))}
+        [selectors/checkbox
+         {:accessibility-label accessibility-label
+          :blur?               blur?
+          :checked?            @checked-state?
+          :on-change           #(swap! checked-state? not)}]
+        [text/text
+         {:size  :paragraph-2
+          :style style/text}
+         label]]])))

src/status_im2/contexts/onboarding/create_password/view.cljs

@@ -165,9 +165,8 @@
          [rn/view {:style style/bottom-part}
           [rn/view {:style style/disclaimer-container}
            [quo/disclaimer
-            {:blur?     true
-             :on-change #(reset! accepts-disclaimer? %)
-             :checked?  @accepts-disclaimer?}
+            {:blur?    true
+             :checked? @accepts-disclaimer?}
             (i18n/label :t/password-creation-disclaimer)]]
 
           (when (= @focused-input :password)