Skip to content

Commit 54d0a89

Browse files
committed
Fix compilation errors for component tests under __tests__ dir
1 parent 338d0fd commit 54d0a89

File tree

11 files changed

+25
-25
lines changed

11 files changed

+25
-25
lines changed

doc/new-guidelines.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ Joshua Comeau.
7979

8080
### Don't prepend booleans with is-
8181

82-
It is a common practice in JavaScript and other languages to prepend boolean variable names with `is-*`.
83-
In ClojureScript it is common practice to suffix boolean variable names with a `?`.
82+
It is a common practice in JavaScript and other languages to prepend boolean variable names with `is-*`.
83+
In ClojureScript it is common practice to suffix boolean variable names with a `?`.
8484
There is no need for both of these and so it is preferable to stick with the latter.
8585

8686
```clojure
@@ -122,11 +122,11 @@ The Status designs have a lot of customization of user and group colors with com
122122

123123
```clojure
124124
;; bad
125-
(defn community-card [{keys [custom-color]}]
125+
(defn community-card [{keys [custom-color]}]
126126
...)
127127

128128
;; good
129-
(defn community-card [{keys [customization-color]}]
129+
(defn community-card [{keys [customization-color]}]
130130
...)
131131
```
132132

@@ -577,9 +577,9 @@ Clojure (JVM) codebases which mirror the sources in a top-level test directory.
577577
└── models_test.cljs
578578
```
579579

580-
Component tests should be created in a separate directory `__tests__`, colocated
581-
with the source. When the entire component implementation is isolated under a
582-
single directory, create a test file named `component_spec.cljs` instead.
580+
Component tests should be created in the same directory as the source component.
581+
When the entire component implementation is isolated under a single directory,
582+
create a test file named `component_spec.cljs` instead.
583583

584584
```
585585
└── filter

src/quo2/components/buttons/__tests__/buttons_component_spec.cljs src/quo2/components/buttons/button_component_spec.cljs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
(ns quo2.components.buttons.--tests--.buttons-component-spec
1+
(ns quo2.components.buttons.button-component-spec
22
(:require ["@testing-library/react-native" :as rtl]
33
[quo2.components.buttons.button :as button]
44
[reagent.core :as reagent]))

src/quo2/components/counter/__tests__/counter_component_spec.cljs src/quo2/components/counter/component_spec.cljs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
(ns quo2.components.counter.--tests--.counter-component-spec
1+
(ns quo2.components.counter.component-spec
22
(:require [quo2.components.counter.counter :as counter]
33
[test-helpers.component :as h]))
44

src/quo2/components/dividers/__tests__/divider_label_component_spec.cljs src/quo2/components/dividers/divider_label_component_spec.cljs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
(ns quo2.components.dividers.--tests--.divider-label-component-spec
1+
(ns quo2.components.dividers.divider-label-component-spec
22
(:require ["@testing-library/react-native" :as rtl]
33
[quo2.components.dividers.divider-label :as divider-label]
44
[reagent.core :as reagent]))

src/quo2/components/markdown/__tests__/text_component_spec.cljs src/quo2/components/markdown/text_component_spec.cljs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
(ns quo2.components.markdown.--tests--.text-component-spec
1+
(ns quo2.components.markdown.text-component-spec
22
(:require ["@testing-library/react-native" :as rtl]
33
[quo2.components.markdown.text :as text]
44
[reagent.core :as reagent]))

src/quo2/components/record_audio/record_audio/__tests__/record_audio_component_spec.cljs src/quo2/components/record_audio/record_audio/component_spec.cljs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
(ns quo2.components.record-audio.record-audio.--tests--.record-audio-component-spec
1+
(ns quo2.components.record-audio.record-audio.component-spec
22
(:require [quo2.components.record-audio.record-audio.view :as record-audio]
33
[react-native.audio-toolkit :as audio]
44
[test-helpers.component :as h]))

src/quo2/components/record_audio/soundtrack/__tests__/soundtrack_component_spec.cljs src/quo2/components/record_audio/soundtrack/component_spec.cljs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
(ns quo2.components.record-audio.soundtrack.--tests--.soundtrack-component-spec
1+
(ns quo2.components.record-audio.soundtrack.component-spec
22
(:require [quo2.components.record-audio.soundtrack.view :as soundtrack]
33
[test-helpers.component :as h]
44
[reagent.core :as reagent]

src/quo2/components/selectors/__tests__/selectors_component_spec.cljs src/quo2/components/selectors/selectors_component_spec.cljs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
(ns quo2.components.selectors.--tests--.selectors-component-spec
1+
(ns quo2.components.selectors.selectors-component-spec
22
(:require ["@testing-library/react-native" :as rtl]
33
[quo2.components.selectors.selectors :as selectors]
44
[reagent.core :as reagent]))
@@ -81,4 +81,4 @@
8181
(render-checkbox-prefill {:on-change mock-fn})
8282
(rtl/fireEvent.press (rtl/screen.getByTestId "checkbox-prefill-component"))
8383
(-> (js/expect mock-fn)
84-
(.toHaveBeenCalledTimes 1)))))
84+
(.toHaveBeenCalledTimes 1)))))

src/quo2/components/tags/__tests__/status_tags_component_spec.cljs src/quo2/components/tags/status_tags_component_spec.cljs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
(ns quo2.components.tags.--tests--.status-tags-component-spec
1+
(ns quo2.components.tags.status-tags-component-spec
22
(:require [quo2.components.tags.status-tags :as quo2]
33
[test-helpers.component :as h]))
44

src/quo2/core_spec.cljs

+8-8
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
(ns quo2.core-spec
22
(:require [quo2.components.avatars.user-avatar.component-spec]
33
[quo2.components.banners.banner.component-spec]
4-
[quo2.components.buttons.--tests--.buttons-component-spec]
5-
[quo2.components.counter.--tests--.counter-component-spec]
6-
[quo2.components.dividers.--tests--.divider-label-component-spec]
4+
[quo2.components.buttons.button-component-spec]
5+
[quo2.components.counter.component-spec]
6+
[quo2.components.dividers.divider-label-component-spec]
77
[quo2.components.dividers.strength-divider.component-spec]
88
[quo2.components.drawers.action-drawers.component-spec]
99
[quo2.components.drawers.drawer-buttons.component-spec]
1010
[quo2.components.drawers.permission-context.component-spec]
1111
[quo2.components.colors.color-picker.component-spec]
1212
[quo2.components.inputs.profile-input.component-spec]
1313
[quo2.components.inputs.title-input.component-spec]
14-
[quo2.components.markdown.--tests--.text-component-spec]
14+
[quo2.components.markdown.text-component-spec]
1515
[quo2.components.onboarding.small-option-card.component-spec]
1616
[quo2.components.password.tips.component-spec]
17-
[quo2.components.record-audio.record-audio.--tests--.record-audio-component-spec]
18-
[quo2.components.record-audio.soundtrack.--tests--.soundtrack-component-spec]
17+
[quo2.components.record-audio.record-audio.component-spec]
18+
[quo2.components.record-audio.soundtrack.component-spec]
1919
[quo2.components.profile.select-profile.component-spec]
20-
[quo2.components.selectors.--tests--.selectors-component-spec]
20+
[quo2.components.selectors.selectors-component-spec]
2121
[quo2.components.selectors.filter.component-spec]
22-
[quo2.components.tags.--tests--.status-tags-component-spec]))
22+
[quo2.components.tags.status-tags-component-spec]))

test/jest/jest.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ module.exports = {
1919
},
2020
testEnvironment: 'node',
2121
rootDir: '../../component-spec',
22-
testMatch: ['**/*__tests__*', '**/*.component_spec.js'],
22+
testMatch: ['**/*.component_spec.js'],
2323
};

0 commit comments

Comments
 (0)