[#19037] fix: address reviewer feedbacks

Author: mohsen-ghafouri

src/status_im/common/validation/profile.cljs

@@ -29,7 +29,7 @@
 (defn validation-name
   [s]
   (cond
-    (or (= s nil) (= s ""))      nil
+    (string/blank? s)            nil
     (string/ends-with? s "-eth") (i18n/label :t/ending-not-allowed {:ending "-eth"})
     (string/ends-with? s "_eth") (i18n/label :t/ending-not-allowed {:ending "_eth"})
     (string/ends-with? s ".eth") (i18n/label :t/ending-not-allowed {:ending ".eth"})
@@ -45,7 +45,7 @@
 (defn validation-bio
   [s]
   (cond
-    (or (= s nil) (= s ""))     nil
+    (string/blank? s)           nil
     (has-emojis? s)             (i18n/label :t/are-not-allowed {:check (i18n/label :t/emojis)})
     (has-special-characters? s) (i18n/label :t/are-not-allowed
                                             {:check (i18n/label :t/special-characters)})
@@ -54,7 +54,7 @@
 (defn validation-nickname
   [s]
   (cond
-    (or (= s nil) (= s ""))     nil
+    (string/blank? s)           nil
     (has-emojis? s)             (i18n/label :t/are-not-allowed {:check (i18n/label :t/emojis)})
     (has-special-characters? s) (i18n/label :t/are-not-allowed
                                             {:check (i18n/label :t/special-characters)})

src/status_im/contexts/profile/contact/add_nickname/view.cljs

@@ -15,7 +15,7 @@
   []
   (let [{:keys [public-key primary-name nickname customization-color]
          :as   profile}                         (rf/sub [:contacts/current-contact])
-        ;; TODO: remove :blue when #18733 merged.
+        ;; TODO(@mohsen): remove :blue, https://github.com/status-im/status-mobile/issues/18733
         customization-color                     (or customization-color :blue)
         full-name                               (profile.utils/displayed-name profile)
         profile-picture                         (profile.utils/photo profile)
@@ -67,8 +67,8 @@
       [info-message/info-message
        {:icon :i/info
         :size :default
-        :type (if (not (string/blank? error-msg)) :error :default)}
-       (if (not (string/blank? error-msg))
+        :type (if-not (string/blank? error-msg) :error :default)}
+       (if-not (string/blank? error-msg)
          error-msg
          (i18n/label :t/nickname-visible-to-you))]]
      [quo/bottom-actions

src/status_im/contexts/profile/contact/view.cljs

@@ -21,7 +21,7 @@
      {:navigate-back?   true
       :height           148
       :on-scroll        #(reanimated/set-shared-value scroll-y %)
-      ;TODO remove colors/primary-50 when #18733 merged.
+      ;; TODO(@mohsen): remove colors/primary-50, https://github.com/status-im/status-mobile/issues/18733
       :cover-color      (or customization-color colors/primary-50)
       :background-color (colors/theme-colors colors/white colors/neutral-95 theme)
       :page-nav-props   {:right-side [{:icon-name :i/options