[#17986] fix: address feedbacks and removed link to new profile to fix e2e issue

Author: mohsen-ghafouri

src/status_im2/common/home/top_nav/view.cljs

@@ -33,7 +33,7 @@
                                            :unread-indicator/new  :mention
                                            nil)]
     [quo/top-nav
-     {:avatar-on-press          #(rf/dispatch [:open-modal :settings])
+     {:avatar-on-press          #(rf/dispatch [:navigate-to :my-profile])
       :scan-on-press            #(js/alert "to be implemented")
       :activity-center-on-press #(rf/dispatch [:activity-center/open])
       :qr-code-on-press         #(dispatch-and-chill [:open-modal :share-shell] 1000)

src/status_im2/contexts/profile/settings/constants.cljs

@@ -0,0 +1,83 @@
+(ns status-im2.contexts.profile.settings.list-items
+  (:require [status-im2.common.not-implemented :as not-implemented]
+            [utils.i18n :as i18n]
+            [utils.re-frame :as rf]))
+
+(def items
+  [[{:title       (i18n/label :t/edit-profile)
+     :on-press    not-implemented/alert
+     :image-props :i/edit
+     :image       :icon
+     :action      :arrow}
+    {:title       (i18n/label :t/password)
+     :on-press    not-implemented/alert
+     :image-props :i/password
+     :image       :icon
+     :action      :arrow}]
+   [{:title       (i18n/label :t/messages)
+     :on-press    not-implemented/alert
+     :image-props :i/messages
+     :image       :icon
+     :action      :arrow}
+    {:title       (i18n/label :t/wallet)
+     :on-press    not-implemented/alert
+     :image-props :i/wallet
+     :image       :icon
+     :action      :arrow}
+    {:title       (i18n/label :t/dapps)
+     :on-press    not-implemented/alert
+     :image-props :i/placeholder
+     :image       :icon
+     :action      :arrow}
+    {:title       (i18n/label :t/browser)
+     :on-press    not-implemented/alert
+     :image-props :i/browser
+     :image       :icon
+     :action      :arrow}
+    {:title       (i18n/label :t/keycard)
+     :on-press    not-implemented/alert
+     :image-props :i/keycard
+     :image       :icon
+     :action      :arrow}]
+   [{:title       (i18n/label :t/syncing)
+     :on-press    not-implemented/alert
+     :image-props :i/syncing
+     :image       :icon
+     :action      :arrow}
+    {:title       (i18n/label :t/notifications)
+     :on-press    not-implemented/alert
+     :image-props :i/notifications
+     :image       :icon
+     :action      :arrow}
+    {:title       (i18n/label :t/appearance)
+     :on-press    not-implemented/alert
+     :image-props :i/light
+     :image       :icon
+     :action      :arrow}
+    {:title       (i18n/label :t/language-and-currency)
+     :on-press    not-implemented/alert
+     :image-props :i/globe
+     :image       :icon
+     :action      :arrow}]
+   [{:title       (i18n/label :t/data-usage)
+     :on-press    not-implemented/alert
+     :image-props :i/mobile
+     :image       :icon
+     :action      :arrow}
+    {:title       (i18n/label :t/advanced)
+     :on-press    not-implemented/alert
+     :image-props :i/settings
+     :image       :icon
+     :action      :arrow}]
+   ;; temporary link to legacy settings
+   [{:title       "Legacy settings"
+     :on-press    #(rf/dispatch [:navigate-to :my-profile])
+     :action      :arrow
+     :image       :icon
+     :image-props :i/toggle}]
+   [{:title    (i18n/label :t/about)
+     :on-press not-implemented/alert
+     :action   :arrow}
+    {:title    (i18n/label :t/status-help)
+     :on-press not-implemented/alert
+     :action   :arrow}]])

src/status_im2/contexts/profile/settings/list_items.cljs

@@ -6,8 +6,8 @@
             [react-native.reanimated :as reanimated]
             [react-native.safe-area :as safe-area]
             [status-im2.common.not-implemented :as not-implemented]
-            [status-im2.contexts.profile.settings.constants :as settings.constants]
             [status-im2.contexts.profile.settings.header.view :as settings.header]
+            [status-im2.contexts.profile.settings.list-items :as settings.items]
             [status-im2.contexts.profile.settings.style :as style]
             [utils.debounce :as debounce]
             [utils.i18n :as i18n]
@@ -56,7 +56,7 @@
                        :on-press  #(debounce/dispatch-and-chill [:open-modal :share-shell] 1000)}]}]]
       [rn/flat-list
        {:header                          [settings.header/view {:scroll-y scroll-y}]
-        :data                            settings.constants/settings-items
+        :data                            settings.items/items
         :key-fn                          :title
         :shows-vertical-scroll-indicator false
         :render-fn                       f-settings-item-view