Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Communities] There is no bottom margin on iPhone SE under the Slide to request to join button #18997

Closed
FFFra opened this issue Feb 26, 2024 · 1 comment · Fixed by #18987
Closed

[Communities] There is no bottom margin on iPhone SE under the Slide to request to join button #18997

FFFra opened this issue Feb 26, 2024 · 1 comment · Fixed by #18987
Assignees
@mohsen-ghafouri
Labels
accessibility Making Status usable by as many people as possible community-permissions https://www.notion.so/The-Four-Guards-64e9c0b6bf2546a6bfc3716bc96dc587
Milestone
2.27.0 Alpha

Comments

@FFFra
Copy link
Contributor

FFFra commented Feb 26, 2024

Follow up #18761

Bug Report

During the refactoring to fix Community rules scroll we discovered that the fix is not perfect on iPhone SE and small devices.

Please check the following comment

Problem

There is no bottom margin on iPhone SE under the Slide to request to join button

Expected behavior

Should looks like Figma

image

Actual behavior

image

Reproduction

  1. Activate the Accounts Selection feature flag.
  2. Input text of maximum length into the 'Dialog for new members' field on the desktop.
  3. Invite a user and attempt to join this community on a mobile device.
  4. Run the app on iPhone SE and verify that the slide is not rendering as expected

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
@FFFra FFFra added the bug label Feb 26, 2024
@FFFra FFFra added this to the 2.27.0 Alpha milestone Feb 26, 2024
@ajayesivan ajayesivan added the community-permissions https://www.notion.so/The-Four-Guards-64e9c0b6bf2546a6bfc3716bc96dc587 label Feb 26, 2024
@ibrkhalil ibrkhalil assigned ibrkhalil and unassigned ibrkhalil Mar 3, 2024
@ibrkhalil
Copy link
Contributor

Duplicate of #18929
CC: @mohsen-ghafouri

@mohsen-ghafouri mohsen-ghafouri mentioned this issue Mar 6, 2024
Merged
@mohsen-ghafouri mohsen-ghafouri self-assigned this Mar 6, 2024
@ilmotta ilmotta added the accessibility Making Status usable by as many people as possible label Oct 4, 2024
@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohsen-ghafouri mohsen-ghafouri

Labels
accessibility Making Status usable by as many people as possible community-permissions https://www.notion.so/The-Four-Guards-64e9c0b6bf2546a6bfc3716bc96dc587
Projects
No open projects
🎭💂 The Four Guards [mobile] (Community Permissions crew)
Status: Done
Milestone
2.27.0 Alpha
Development

Successfully merging a pull request may close this issue.

[#18929] fix: no bottom space under the join button status-im/status-mobile
5 participants
@ilmotta @FFFra @ajayesivan @ibrkhalil @mohsen-ghafouri