Skip to content

Commit 611fed3

Browse files
bench: refactor random number generation in stats/base/dists/erlang
PR-URL: #4916 Reviewed-by: Athan Reines <[email protected]>
1 parent 3250d4f commit 611fed3

File tree

13 files changed

+329
-104
lines changed

13 files changed

+329
-104
lines changed

lib/node_modules/@stdlib/stats/base/dists/erlang/cdf/benchmark/benchmark.js

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var ceil = require( '@stdlib/math/base/special/ceil' );
25-
var randu = require( '@stdlib/random/base/randu' );
24+
var Float64Array = require( '@stdlib/array/float64' );
25+
var uniform = require( '@stdlib/random/base/uniform' );
26+
var discreteUniform = require( '@stdlib/random/base/discrete-uniform' );
2627
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2728
var EPS = require( '@stdlib/constants/float64/eps' );
2829
var pkg = require( './../package.json' ).name;
@@ -33,17 +34,25 @@ var cdf = require( './../lib' );
3334

3435
bench( pkg, function benchmark( b ) {
3536
var lambda;
37+
var len;
3638
var k;
3739
var x;
3840
var y;
3941
var i;
4042

43+
len = 100;
44+
x = new Float64Array( len );
45+
k = new Float64Array( len );
46+
lambda = new Float64Array( len );
47+
for ( i = 0; i < len; i++ ) {
48+
x[ i ] = discreteUniform( 0, 100 );
49+
k[ i ] = discreteUniform( 0, 100 );
50+
lambda[ i ] = uniform( EPS, 20.0 );
51+
}
52+
4153
b.tic();
4254
for ( i = 0; i < b.iterations; i++ ) {
43-
x = ceil( randu()*100.0 );
44-
k = ceil( randu()*100.0 );
45-
lambda = ( randu()*20.0 ) + EPS;
46-
y = cdf( x, k, lambda );
55+
y = cdf( x[ i % len ], k[ i % len ], lambda[ i % len ] );
4756
if ( isnan( y ) ) {
4857
b.fail( 'should not return NaN' );
4958
}
@@ -59,6 +68,7 @@ bench( pkg, function benchmark( b ) {
5968
bench( pkg+':factory', function benchmark( b ) {
6069
var lambda;
6170
var mycdf;
71+
var len;
6272
var k;
6373
var x;
6474
var y;
@@ -67,11 +77,15 @@ bench( pkg+':factory', function benchmark( b ) {
6777
k = 2.0;
6878
lambda = 1.5;
6979
mycdf = cdf.factory( k, lambda );
80+
len = 100;
81+
x = new Float64Array( len );
82+
for ( i = 0; i < len; i++ ) {
83+
x[ i ] = uniform( EPS, 50.0 );
84+
}
7085

7186
b.tic();
7287
for ( i = 0; i < b.iterations; i++ ) {
73-
x = ( randu()*50.0 ) + EPS;
74-
y = mycdf( x );
88+
y = mycdf( x[ i % len ]);
7589
if ( isnan( y ) ) {
7690
b.fail( 'should not return NaN' );
7791
}

0 commit comments

Comments
 (0)